-
-
Notifications
You must be signed in to change notification settings - Fork 652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename fmt2
to fmt
and lint2
to lint
#9257
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really nice to see! 😄
@@ -37,7 +18,6 @@ def act_transitively(self): | |||
def determine_if_skipped(self, *, formatter_subsystem: Subsystem) -> bool: | |||
# TODO: generalize this to work with every formatter, not only scalafix. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe now it's not in the same file anymore, I would add a sentence to this comment to say: "when doing this, remember to change the help description for --only
in rules/core/fmt.py
." I could see us forgetting that otherwise.
Note: This CI failure looks like a legit failure caused by this change: https://travis-ci.com/pantsbuild/pants/jobs/295575406
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Woo!
I had fixed the lint test, not the fmt test. Oops.
Closes #8351.
It's safe to make this change, even with us defaulting to
--v2
for users, because we default to no V2 linters being enabled and the V2 goal no-ops in this case.It's also safe to have both V1 and V2 linters run at the same time (mixed mode). They won't run at the same time, so there's no risk of formatters conflicting with each other.
In a followup, we can now deprecate V1 isort for the V2 implementation.