Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare 2.25.0.dev1 #21733

Merged
merged 1 commit into from
Dec 12, 2024
Merged

Prepare 2.25.0.dev1 #21733

merged 1 commit into from
Dec 12, 2024

Conversation

stuhood
Copy link
Member

@stuhood stuhood commented Dec 7, 2024

No description provided.

@stuhood stuhood added automation:release-prep Preparation for doing a release, created by automation category:internal CI, fixes for not-yet-released features, etc. labels Dec 7, 2024
@stuhood stuhood self-assigned this Dec 7, 2024
@stuhood stuhood requested review from benjyw and cburroughs December 7, 2024 23:53
@cburroughs
Copy link
Contributor

psutil/_psutil_common.c:9:10: fatal error: Python.h: No such file or directory
pip:           9 | #include <Python.h>
pip:             |          ^~~~~~~~~~
pip:       compilation terminated.
pip:       psutil could not be installed from sources. Perhaps Python header files are not installed. Try running:
pip:         sudo yum install gcc python3-devel
pip:       error: command '/opt/rh/gcc-toolset-13/root/usr/bin/gcc' failed with exit code 1
pip:       [end of output]

:-( I thought we adjusted the wheel builds so they would be tested before a release, but I guess not. Sorry you found one of the rakes to step on!

@benjyw
Copy link
Contributor

benjyw commented Dec 11, 2024

I'm trying to debug this. On a new AWS instance with the same AMI running pants manually works. Next to try is ssh into the runner and poke around. But the runner is terminated once the CI fails, so will have to modify it to sleep for a while. Will push to the branch for this purpose.

@benjyw benjyw force-pushed the automation/release/2.25.0.dev1 branch 2 times, most recently from 1ea6ba4 to 873a439 Compare December 11, 2024 23:17
@benjyw
Copy link
Contributor

benjyw commented Dec 11, 2024

OK, looks like we need to yum install -y python3.11-devel inside the manylinux container (the pythons on the host AMI are irrelevant for wheel building, although those are the ones we use for tests etc.)

@benjyw benjyw force-pushed the automation/release/2.25.0.dev1 branch from 873a439 to 9abe31b Compare December 12, 2024 02:23
@benjyw
Copy link
Contributor

benjyw commented Dec 12, 2024

Rebased this on top of #21749, which fixes pex building in CI. Hopefully it'll go green now.

@benjyw benjyw merged commit b4c218b into main Dec 12, 2024
24 checks passed
@benjyw benjyw deleted the automation/release/2.25.0.dev1 branch December 12, 2024 02:58
@cburroughs
Copy link
Contributor

I thought we adjusted the wheel builds so they would be tested before a release, but I guess not.

To answer my own builds, we now build wheels on ci config changes, but not on every PR. I'm still unsure what regressed between 2.25.0.dev0 (already on Python 3.11) and this though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automation:release-prep Preparation for doing a release, created by automation category:internal CI, fixes for not-yet-released features, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants