Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Install Python headers in the ARM64 wheel-building container. #21749

Merged
merged 1 commit into from
Dec 12, 2024
Merged

Install Python headers in the ARM64 wheel-building container. #21749

merged 1 commit into from
Dec 12, 2024

Conversation

benjyw
Copy link
Contributor

@benjyw benjyw commented Dec 11, 2024

This fixes a CI error due to our switch to Python 3.11.

@benjyw benjyw added the category:internal CI, fixes for not-yet-released features, etc. label Dec 11, 2024
@benjyw benjyw requested review from cburroughs and tdyas December 11, 2024 23:43
@benjyw
Copy link
Contributor Author

benjyw commented Dec 11, 2024

This was tested by manually pushing to the 2.25.0.dev1 release branch.

@tdyas
Copy link
Contributor

tdyas commented Dec 12, 2024

Maybe better to just have this package installed in the AMI used for these runners?

@benjyw
Copy link
Contributor Author

benjyw commented Dec 12, 2024

It is already installed in that AMI. But this is installing it inside the manylinux container we use for wheel/pex building.

The AMI has glibc 2.36, and we need 2.28 for manylinux_2_28 compatibility. Hence the need to build in a container.

@tdyas
Copy link
Contributor

tdyas commented Dec 12, 2024

It is already installed in that AMI. But this is installing it inside the manylinux container we use for wheel/pex building.

The AMI has glibc 2.36, and we need 2.28 for manylinux_2_28 compatibility. Hence the need to build in a container.

Understood. Makes sense.

@benjyw benjyw merged commit e2e0b0c into pantsbuild:main Dec 12, 2024
24 checks passed
@benjyw benjyw deleted the fix_arm_ci branch December 12, 2024 02:20
@benjyw benjyw mentioned this pull request Dec 12, 2024
Merged
cburroughs
cburroughs reviewed Dec 12, 2024
View reviewed changes
src/python/pants_release/generate_github_workflows.py
*([] if platform == Platform.LINUX_ARM64 else [install_go()]),
*(
[install_python_headers_in_manylinux_container()]
if platform == Platform.LINUX_ARM64
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I presume this builds in the x86_64 containers because the package happens to already be installed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess so, some small difference between the two images.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cburroughs cburroughs cburroughs left review comments

@tdyas tdyas tdyas approved these changes

Assignees
No one assigned
Labels
category:internal CI, fixes for not-yet-released features, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@benjyw @tdyas @cburroughs