feat(rpc): initial work in eth_call+estimate #1514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
added
C-enhancement
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #1514 +/- ##
==========================================
- Coverage 76.07% 75.92% -0.15%
==========================================
Files 358 359 +1
Lines 42759 42805 +46
==========================================
- Hits 32528 32501 -27
- Misses 10231 10304 +73
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
gakonst
reviewed
Feb 22, 2023
| use reth_primitives::{BlockId, U256}; | ||
| use reth_provider::{BlockProvider, StateProvider, StateProviderFactory}; | ||
| use reth_rpc_types::CallRequest; | ||
| use revm::primitives::{BlockEnv, Env, ResultAndState}; |
There was a problem hiding this comment.
let's re-export these from reth_executor
Comment on lines
+34
to
+39
| let mut db = SubState::new(State::new(state)); | ||
| let mut evm = revm::EVM::new(); | ||
| evm.env = self.build_call_env(request, block_env); | ||
| evm.database(db); | ||
| // TODO error conversion from EMVError to EthApiErr | ||
| let res = evm.transact_ref().unwrap(); |
There was a problem hiding this comment.
We'll probably want to push these helpers to the executor, and have the API maybe own an executor/reference to one?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
initial scaffolding for eth_call+estimate ref #1504
I will come up with something along the way and would like to make the changes incrementally rather than submitting them as a whole. because this will become quite large.
for now, this just outlines some functions for eth_call and estimate.
next step is figuring out how to actually create the
Env, then porting some logic from anvil.