-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(rpc): initial work in eth_call+estimate #1514
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,64 @@ | ||
//! Contains RPC handler implementations specific to endpoints that call/execute within evm. | ||
|
||
#![allow(unused)] // TODO rm later | ||
|
||
use crate::{eth::error::EthResult, EthApi}; | ||
use reth_executor::revm_wrap::{State, SubState}; | ||
use reth_primitives::{BlockId, U256}; | ||
use reth_provider::{BlockProvider, StateProvider, StateProviderFactory}; | ||
use reth_rpc_types::CallRequest; | ||
use revm::primitives::{BlockEnv, Env, ResultAndState}; | ||
|
||
impl<Client, Pool, Network> EthApi<Client, Pool, Network> | ||
where | ||
Client: BlockProvider + StateProviderFactory + 'static, | ||
{ | ||
/// Creates the [Env] used by the [EVM](revm::EVM) when executing a call. | ||
fn build_call_env(&self, request: CallRequest, block_env: BlockEnv) -> Env { | ||
todo!() | ||
} | ||
|
||
/// Executes the call request against the given `state` without committing any changes to the | ||
/// database | ||
pub(crate) fn call_with<S>( | ||
&self, | ||
request: CallRequest, | ||
state: S, | ||
block_env: BlockEnv, | ||
// TODO add overrides | ||
) -> EthResult<ResultAndState> | ||
where | ||
S: StateProvider, | ||
{ | ||
// the revm database impl | ||
let mut db = SubState::new(State::new(state)); | ||
let mut evm = revm::EVM::new(); | ||
evm.env = self.build_call_env(request, block_env); | ||
evm.database(db); | ||
// TODO error conversion from EMVError to EthApiErr | ||
let res = evm.transact_ref().unwrap(); | ||
Comment on lines
+34
to
+39
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We'll probably want to push these helpers to the executor, and have the API maybe own an executor/reference to one? |
||
Ok(res) | ||
} | ||
|
||
/// Estimate gas needed for execution of the `request` at the [BlockId] . | ||
pub(crate) fn estimate_gas_at(&self, mut request: CallRequest, at: BlockId) -> EthResult<U256> { | ||
// TODO get a StateProvider for the given blockId and BlockEnv | ||
todo!() | ||
} | ||
|
||
/// Estimates the gas usage of the `request` with the state. | ||
fn estimate_gas_with<S>( | ||
&self, | ||
mut request: CallRequest, | ||
state: S, | ||
block_env: BlockEnv, | ||
) -> EthResult<U256> | ||
where | ||
S: StateProvider, | ||
{ | ||
// TODO: check if transfer | ||
// binary search over range to find best gas | ||
|
||
todo!() | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's re-export these from
reth_executor