Resolve realpath

[dishuostec]

Origin pull request #4939

I fixed all test #4939 (comment)

[height]

Link Height tasks by mentioning a task ID in the pull request title or description, commit messages, or comments.

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

[aminya]

Wow! This is awesome. Excited to see this in action. Should we revive the pnpm PR as well after this is merged?

[jasonswearingen]

Should we revive the pnpm PR as well after this is merged?

Please do, I have been tracking this issue for that very reason.

[dishuostec]

Wow! This is awesome. Excited to see this in action. Should we revive the pnpm PR as well after this is merged?

I have tested pnpm with this pr, it works fine and no more duplicate depenndency.

[aminya]

I want to request the maintainers to review this if they can and let us know if there is anything we can do to get this through. I'm afraid that other pull requests introduce conflicts with this, like how it happened for the old PR. 😄

cc: @mischnic @DeMoorJasper @devongovett etc

[aminya]

Anything else remaining here? What's the procedure for merging something into Parcel? It's a little unclear how the PRs work in Parcel considering that this (or its related PR) has been open for a couple of months now.

[jasonswearingen]

@devongovett please consider accepting this PR. It or it's predecessor have been around for 5 months and dishuostec got it mergeable twice.

[aminya]

I have made a fork of Parcel that includes this PR and #4920. However, I am not familiar with the registration procedure for this repository because it uses Lerna, Yarn, Gulp, etc. If anyone is familiar with the process, let me know in this issue:
aminya#4

[aminya]

I merged V2 into this branch and ran the tests. Everything works without any issues.

I only had to increase this time out to 30000 on my machine for this flaky test.

parcel/packages/core/core/test/AssetGraphBuilder.test.js

Lines 10 to 12 in a4cf3e9

	// This depends on spinning up a WorkerFarm, which can take some time.
	this.timeout(20000);

CC: @wbinnssmith @mischnic

[aminya]

@DeMoorJasper Why is bundle undefined in parcel-benchmark-action? This seems strange.
https://github.com/parcel-bundler/parcel-benchmark-action/blob/75a86fd8b9815657df9a8f46a9ab762016ed2838/src/utils/compare-benchmarks.ts#L46

[devongovett]

I apologize for the slow response to this PR. I am also making some changes to the resolver in #5481, so I will update this and make a new PR with those changes merged in. Thanks again for your contribution!

[devongovett]

Pretty sure this will always be true. The FS module returns the original path if there is no realpath https://github.com/parcel-bundler/parcel/blob/v2/packages/core/fs/src/NodeFS.js#L82

[devongovett]

I believe this is slightly different from what Node does. This only considers symlinked directories whereas node also supports symlinked files. I believe Node basically just takes the realpath at the end after everything has been resolved. This would also avoid the need for the isSymlink flag because the symlink path would be used until the very end of the algorithm.

[devongovett]

See #5508