Resolve realpath in default resolver #5508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Amin Yahyaabadi <[email protected]>
Co-authored-by: Amin Yahyaabadi <[email protected]>
Co-authored-by: Amin Yahyaabadi <[email protected]>
Co-authored-by: Amin Yahyaabadi <[email protected]>
… into realpath # Conflicts: # packages/utils/node-resolver-core/src/NodeResolver.js
|
This was referenced Dec 20, 2020
Closed
Benchmark ResultsKitchen Sink ✅
Timings
Cold Bundles
Cached Bundles
React HackerNews ✅
Timings
Cold Bundles
Cached Bundles
AtlasKit Editor ✅
Timings
Cold Bundles
Cached Bundles
Three.js ✅
Timings
Cold BundlesNo bundle changes detected. Cached Bundles
|
DeMoorJasper
approved these changes
Dec 21, 2020
|
Great to see this merged. Can we revive this PR too? |
|
Thank you soooo much for finally doing and merging this 🤗❤️ A ginormous pain in the ass is now gone. I just have to update everything to parcel 2 nightly and no longer care about how I import my dependencies :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5183. Depends on #5481.
This is based on #5183 but with a slightly different strategy that matches Node behavior: we take the realpath at the very end rather than only of the module directory. This also allows files to be symlinks. I also added some tests for this.
Also removed the unnecessary realpath calls in other places around parcel now that asset file paths are never symlinks.