Skip to content
This repository has been archived by the owner on Feb 28, 2023. It is now read-only.

chore: fork-a-🕓 #50

Merged
merged 9 commits into from
Jul 15, 2021
Merged

chore: fork-a-🕓 #50

merged 9 commits into from
Jul 15, 2021

Conversation

drahnr
Copy link
Contributor

@drahnr drahnr commented Apr 27, 2021

Since roughly a year we've been attempting to find a way to work with upstream, but it seems there is a lack of resources to just review PRs.

Given the need on our end to significantly adapt the internal structure, this is sub optimal which lead to this PR.

I wanted to defer this to the latest point, but it seems the time has come. I'd rather not.

@drahnr drahnr self-assigned this Apr 27, 2021
@drahnr drahnr force-pushed the bernhard-fork-a-clock branch 5 times, most recently from 5695ccd to 557965e Compare April 29, 2021 14:11
@Xanewok
Copy link
Contributor

Xanewok commented Apr 29, 2021

It's also worth noting that the cc internally hardcodes valid wrappers, which includes sccache:
https://github.com/alexcrichton/cc-rs/blob/c8b47ee8b53a57a505ecd0f0981c1bb3b4b58fb4/src/lib.rs#L2254
https://github.com/alexcrichton/cc-rs/blob/c8b47ee8b53a57a505ecd0f0981c1bb3b4b58fb4/src/lib.rs#L2207

So if we're 150% commited on a new name and a new 'brand', we'd need to add ourselves to the list in order not to lose C/C++ build acceleration (in contrast with using vanilla sccache bin name)

@drahnr
Copy link
Contributor Author

drahnr commented Apr 30, 2021

Good point, but I think that's for once we got a release out the door :)

@drahnr
Copy link
Contributor Author

drahnr commented Jul 8, 2021

Rebased this onto master, should be merged after #86 and #84

@drahnr drahnr requested a review from Xanewok July 9, 2021 07:08
@Xanewok Xanewok added this to the cachepot deployment milestone Jul 11, 2021
@Xanewok Xanewok force-pushed the bernhard-fork-a-clock branch from ac72309 to e3ce18d Compare July 11, 2021 17:42
@Xanewok Xanewok merged commit 359c498 into master Jul 15, 2021
@Xanewok Xanewok deleted the bernhard-fork-a-clock branch July 15, 2021 17:31
@drahnr
Copy link
Contributor Author

drahnr commented Jul 15, 2021

🎉

@drahnr drahnr mentioned this pull request Jul 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants