This repository has been archived by the owner on Feb 28, 2023. It is now read-only.
dep info envs #84
Merged
dep info envs #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drahnr
force-pushed
the
bernhard-dep-info-envs
branch
5 times, most recently
from
4a66002 to
3fc2ade
Compare
drahnr
force-pushed
the
bernhard-dep-info-envs
branch
3 times, most recently
from
e788ab0 to
2798c3b
Compare
|
@Xanewok getting random CI failures, unrelated to the changeset, could you do a quick review? Escaping is something left as a TODO but I think that is fine for now. I'd like to address that after doing the re-branding. |
Merged
Xanewok
approved these changes
Jul 11, 2021
| // collect the env variables referenced via `env!` or required by `build.rs`. | ||
| const ENV_DEP_PREFIX: &str = "# env-dep:"; | ||
| let mut dep_envs = lines | ||
| .filter(|line| line.starts_with(ENV_DEP_PREFIX) && line.len() > ENV_DEP_PREFIX.len()) |
There was a problem hiding this comment.
It'd be good to use strip_prefix API but since that's introduced in 1.45 it'd be great to leave a note stating that we should upgrade to that once we bump MSRV
Closed
Xanewok
force-pushed
the
bernhard-dep-info-envs
branch
from
2798c3b to
f199fa6
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parses the
# env-dep:info provided by rustc to be less yolo about which env variables to include for remote compilation.Ref #83