This repository has been archived by the owner on Feb 26, 2020. It is now read-only.
Make the crate cross-compilation-friendly #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @debris @arkpar @andresilva (I don't know who to ping exactly |
andresilva
approved these changes
Dec 10, 2018
| let mut base_config = cc::Build::new(); | ||
| base_config.include("."); | ||
| base_config.include("libusb/libusb"); | ||
|
|
||
| if cfg!(target_os = "macos") { | ||
| if target_os == "macos" { |
There was a problem hiding this comment.
Do these always match or should we use contains instead for all checks?
There was a problem hiding this comment.
I assume that CARGO_CFG_TARGET_OS contains the same value as cfg!(target_os), and right now it works by matching exactly, so I suppose it will still continue to work by matching exactly.
|
👍 |
This was referenced Dec 12, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1
Uses undocumented stuff. However it looks like a lot of people are using these variables, so I suppose it's fine.
If Cargo breaks backwards compatibility, Parity's CI will detect it.