Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chain-specific runtime message-delivery API #457

Closed
svyatonik opened this issue Oct 26, 2020 · 1 comment · Fixed by #503
Closed

Chain-specific runtime message-delivery API #457

svyatonik opened this issue Oct 26, 2020 · 1 comment · Fixed by #503

Comments

@svyatonik
Copy link
Contributor

Right now message delivery APIs (OutboundLaneApi and InboundLaneApi) are not chain-specific and thus the runtime can't provide APIs to bridge more than one chain. The way we have solved this in headers sync is that we have separate API trait for every chain (i.e. RialtoHeaderApi and MillauHeaderApi). The same should be done here - i.e. we should have RialtoOutboundLaneApi, RialtoInboundLaneApi, MillauOutboundLaneApi and MillauInboundLaneApi.

The alternative implementation is to add additional argument (instance: InstanceId) to all methods. It is hard-to implement in the runtime (without some macro helpers), but it is more convenient for the relay. So probably worth trying this option and then in separate PR also migrate HeaderApi to that version.

@tomusdrw
Copy link
Contributor

Related: #2491

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants