Chain specific message lane apis #503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HCastano
changed the base branch from
master
to
limit-messages-weight-in-batch
HCastano
approved these changes
Nov 17, 2020
There was a problem hiding this comment.
I think it's a little unfortunate that there's no nice way to do this right now. Although I imagine it wouldn't be too difficult or controversial to add an Into<String> implementation (or something similar) to the runtime API macros in Substrate.
As far as having separate runtime APIs goes, I also think it would be nice to see the macros accept a generic argument and that was we can reuse the same API with different types (so in our case different instances of the chains). That might be a bit harder to do though.
svyatonik
force-pushed
the
chain-specific-message-lane-apis
branch
from
78aeb01 to
c099b83
Compare
Co-authored-by: Hernando Castano <[email protected]>
svyatonik
pushed a commit
that referenced
this pull request
Jul 17, 2023
serban300
pushed a commit
to serban300/parity-bridges-common
that referenced
this pull request
Mar 27, 2024
* replace generic message lane APIs with chain-specific * moved SubstrateHeadersSyncPipeline to headers_pipeline.rs * substrate-specific message lane trait * Update relays/substrate/src/messages_lane.rs Co-authored-by: Hernando Castano <[email protected]> Co-authored-by: Hernando Castano <[email protected]>
serban300
pushed a commit
to serban300/parity-bridges-common
that referenced
this pull request
Apr 8, 2024
* replace generic message lane APIs with chain-specific * moved SubstrateHeadersSyncPipeline to headers_pipeline.rs * substrate-specific message lane trait * Update relays/substrate/src/messages_lane.rs Co-authored-by: Hernando Castano <[email protected]> Co-authored-by: Hernando Castano <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #457
on top of #496 => draft
I've tried all possible options, including:
InstanceIdargument;InstanceIdargument);declare_message_lane_runtime_apis!(Rialto)(failed, because I have found no way to call proc macro from decl macro);decl_runtime_apisthat will generate these string constants, but apparently there's no way to call proc macro from other proc macro. Probably good idea to have this in original substrate macro in the future