Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Commit

Permalink
paras: fix placeholder weight (#4625)
Browse files Browse the repository at this point in the history
Setting zero as weight may be a source of problems.

The problem is, a rogue validator can shove a lot of duplicated votes
and thus fill a block with work that may well exceed the weight limit.
  • Loading branch information
pepyakin authored and drahnr committed Jan 4, 2022
1 parent b5ee4d3 commit 28fe46b
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion runtime/parachains/src/paras.rs
Original file line number Diff line number Diff line change
Expand Up @@ -765,7 +765,7 @@ pub mod pallet {

/// Includes a statement for a PVF pre-checking vote. Potentially, finalizes the vote and
/// enacts the results if that was the last vote before achieving the supermajority.
#[pallet::weight(0)]
#[pallet::weight(Weight::MAX)]
pub fn include_pvf_check_statement(
origin: OriginFor<T>,
stmt: PvfCheckStatement,
Expand Down

0 comments on commit 28fe46b

Please sign in to comment.