This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
paras: fix placeholder weight #4625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Setting zero as weight may be a source of problems. The problem is, a rogue validator can shove a lot of duplicated votes and thus fill a block with work that may well exceed the weight limit.
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
pepyakin
added
B0-silent
sandreim
approved these changes
Dec 28, 2021
| @@ -765,7 +765,7 @@ pub mod pallet { | |||
|
|
|||
| /// Includes a statement for a PVF pre-checking vote. Potentially, finalizes the vote and | |||
| /// enacts the results if that was the last vote before achieving the supermajority. | |||
| #[pallet::weight(0)] | |||
| #[pallet::weight(Weight::MAX)] | |||
There was a problem hiding this comment.
Should we also create an issue to benchmark and replace with proper value, later ?
There was a problem hiding this comment.
Although it doesn't have a separate issue (at least for now) it is being tracked by #3211
drahnr
pushed a commit
that referenced
this pull request
Jan 4, 2022
Setting zero as weight may be a source of problems. The problem is, a rogue validator can shove a lot of duplicated votes and thus fill a block with work that may well exceed the weight limit.
Wizdave97
pushed a commit
to ComposableFi/polkadot
that referenced
this pull request
Feb 3, 2022
Setting zero as weight may be a source of problems. The problem is, a rogue validator can shove a lot of duplicated votes and thus fill a block with work that may well exceed the weight limit.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting zero as weight may be a source of problems.
The problem is, a rogue validator can shove a lot of duplicated votes
and thus fill a block with work that may well exceed the weight limit.