Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Companion for Generate storage info for pallet babe #9760 #3831

Merged
11 commits merged into from
Sep 22, 2021
Merged

Companion for Generate storage info for pallet babe #9760 #3831

11 commits merged into from
Sep 22, 2021

Conversation

georgesdib
Copy link
Contributor

@georgesdib georgesdib commented Sep 12, 2021 •
edited
Loading

Companion to paritytech/substrate#9760

Adding MaxAuthorities to pallet babe

@shawntabrizi @KiChjang @thiolliere

@georgesdib georgesdib mentioned this pull request Sep 12, 2021
Merged
@georgesdib georgesdib marked this pull request as ready for review September 12, 2021 15:59
@KiChjang
Copy link
Contributor

Polkadot companion CI is complaining:

error[E0046]: not all trait items implemented, missing: `MaxAuthorities`
   --> runtime/common/src/integration_tests.rs:113:1
    |
113 | impl pallet_babe::Config for Test {
    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ missing `MaxAuthorities` in implementation
    |
    = help: implement the missing item: `type MaxAuthorities = Type;`

@georgesdib
Copy link
Contributor Author

Polkadot companion CI is complaining:

error[E0046]: not all trait items implemented, missing: `MaxAuthorities`
   --> runtime/common/src/integration_tests.rs:113:1
    |
113 | impl pallet_babe::Config for Test {
    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ missing `MaxAuthorities` in implementation
    |
    = help: implement the missing item: `type MaxAuthorities = Type;`

Fixed

@gui1117 gui1117 added A4-companion A PR that needs a companion PR to merge in parallel for one of its downstream dependencies. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit. labels Sep 22, 2021
@ghost
Copy link

ghost commented Sep 22, 2021

Waiting for commit status.

@ghost ghost merged commit 9e43470 into paritytech:master Sep 22, 2021
rphmeier pushed a commit that referenced this pull request Sep 23, 2021
@emostov @gui1117 @dependabot
Benchmark Disputes force_unfreeze extrinsic (#3908)
ff2b5e9 
* Companion for Generate storage info for pallet babe #9760 (#3831)

* Adding MaxSegmentLength and MaxAuthorities
to pallet babe

* Missed a few to_vec

* Removing `MaxSegmentLength` as not needed anymore

* Adding `MaxAuthorities` to couple of missing place

* Adding missing definition of `MaxAuthorities`

* Adding a missing to_vec

* update Substrate

Co-authored-by: thiolliere <[email protected]>
Co-authored-by: parity-processbot <>

* Benchmark Disputes `force_unfreeze` extrinsic

target pr: #3906
target branch: rh-unfreeze

* Add benchmark to rococo runtime; run benchmark locally

* Revert unintentionally added diff

* Some spacing and comments

* Bump proc-macro-crate from 1.0.0 to 1.1.0 (#3863)

Bumps [proc-macro-crate](https://github.com/bkchr/proc-macro-crate) from 1.0.0 to 1.1.0.
- [Release notes](https://github.com/bkchr/proc-macro-crate/releases)
- [Commits](https://github.com/bkchr/proc-macro-crate/commits)

---
updated-dependencies:
- dependency-name: proc-macro-crate
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump parity-scale-codec from 2.2.0 to 2.3.0 (#3833)

Bumps [parity-scale-codec](https://github.com/paritytech/parity-scale-codec) from 2.2.0 to 2.3.0.
- [Release notes](https://github.com/paritytech/parity-scale-codec/releases)
- [Changelog](https://github.com/paritytech/parity-scale-codec/blob/master/CHANGELOG.md)
- [Commits](paritytech/parity-scale-codec@v2.2...parity-scale-codec-v2.3.0)

---
updated-dependencies:
- dependency-name: parity-scale-codec
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Use super::WeightInfo to try and get CI to compile

* cargo run --quiet --release --features runtime-benchmarks -- benchmark --chain=rococo-dev --steps=50 --repeat=20 --pallet=runtime_parachains::disputes --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./runtime/parachains/src/disputes/weights.rs --header=./file_header.txt

* impl TestWeightInfo; remove weights from runtime_parachains dir

* fmt

* Update test-runtime

Co-authored-by: Georges <[email protected]>
Co-authored-by: thiolliere <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Parity Bot <[email protected]>
ghost pushed a commit that referenced this pull request Sep 23, 2021
@rphmeier @emostov
@gui1117 @dependabot
Add a force_unfreeze extrinsic to the disputes module (#3906)
80a0bfd 
* add a 'force_unfreeze' to the Disputes module

* fmt

* Benchmark Disputes `force_unfreeze` extrinsic (#3908)

* Companion for Generate storage info for pallet babe #9760 (#3831)

* Adding MaxSegmentLength and MaxAuthorities
to pallet babe

* Missed a few to_vec

* Removing `MaxSegmentLength` as not needed anymore

* Adding `MaxAuthorities` to couple of missing place

* Adding missing definition of `MaxAuthorities`

* Adding a missing to_vec

* update Substrate

Co-authored-by: thiolliere <[email protected]>
Co-authored-by: parity-processbot <>

* Benchmark Disputes `force_unfreeze` extrinsic

target pr: #3906
target branch: rh-unfreeze

* Add benchmark to rococo runtime; run benchmark locally

* Revert unintentionally added diff

* Some spacing and comments

* Bump proc-macro-crate from 1.0.0 to 1.1.0 (#3863)

Bumps [proc-macro-crate](https://github.com/bkchr/proc-macro-crate) from 1.0.0 to 1.1.0.
- [Release notes](https://github.com/bkchr/proc-macro-crate/releases)
- [Commits](https://github.com/bkchr/proc-macro-crate/commits)

---
updated-dependencies:
- dependency-name: proc-macro-crate
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump parity-scale-codec from 2.2.0 to 2.3.0 (#3833)

Bumps [parity-scale-codec](https://github.com/paritytech/parity-scale-codec) from 2.2.0 to 2.3.0.
- [Release notes](https://github.com/paritytech/parity-scale-codec/releases)
- [Changelog](https://github.com/paritytech/parity-scale-codec/blob/master/CHANGELOG.md)
- [Commits](paritytech/parity-scale-codec@v2.2...parity-scale-codec-v2.3.0)

---
updated-dependencies:
- dependency-name: parity-scale-codec
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Use super::WeightInfo to try and get CI to compile

* cargo run --quiet --release --features runtime-benchmarks -- benchmark --chain=rococo-dev --steps=50 --repeat=20 --pallet=runtime_parachains::disputes --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./runtime/parachains/src/disputes/weights.rs --header=./file_header.txt

* impl TestWeightInfo; remove weights from runtime_parachains dir

* fmt

* Update test-runtime

Co-authored-by: Georges <[email protected]>
Co-authored-by: thiolliere <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Parity Bot <[email protected]>

Co-authored-by: Zeke Mostov <[email protected]>
Co-authored-by: Georges <[email protected]>
Co-authored-by: thiolliere <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Parity Bot <[email protected]>
@georgesdib georgesdib deleted the babe-storage-info branch September 23, 2021 20:59
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gui1117 gui1117 gui1117 approved these changes

@KiChjang KiChjang KiChjang approved these changes

Assignees
No one assigned
Labels
A4-companion A PR that needs a companion PR to merge in parallel for one of its downstream dependencies. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@georgesdib @KiChjang @gui1117