Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Generate storage info for pallet babe #9760

Merged
11 commits merged into from
Sep 22, 2021
Merged

Generate storage info for pallet babe #9760

11 commits merged into from
Sep 22, 2021

Conversation

georgesdib
Copy link
Contributor

@georgesdib georgesdib commented Sep 12, 2021 •
edited
Loading

Fixes part of paritytech/polkadot-sdk#323

Adding storage_info to pallet babe. Adding a few MaxEncodedLen to facilitate this, and converting Vec to WeakBoundedVec and BoundedVec

Polkadot companion paritytech/polkadot#3831

@shawntabrizi @KiChjang @thiolliere

Georges Dib added 3 commits September 12, 2021 15:53
Adding MaxEncodedLen for:
7da67f7 
* NextConfigDescriptor
* AllowedSlots
* BabeEpochConfiguration

In prepation for adding storage information on pallet babe
Adding stotage_info to pallet babe
7837573 
Refactored UNDER_CONSTRUCTION_SEGMENT_LENGTH to become a runtime
parameter MaxSegmentLength
Merge branch 'paritytech:master' into master
a0b0b45
@georgesdib georgesdib mentioned this pull request Sep 12, 2021
Merged
@georgesdib georgesdib marked this pull request as ready for review September 12, 2021 15:59
KiChjang
KiChjang reviewed Sep 20, 2021
View reviewed changes
frame/babe/src/lib.rs Outdated Show resolved Hide resolved
KiChjang
KiChjang reviewed Sep 20, 2021
View reviewed changes
frame/babe/src/lib.rs Outdated Show resolved Hide resolved
gui1117
gui1117 approved these changes Sep 21, 2021
View reviewed changes
Copy link
Contributor

@gui1117 gui1117 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me but I would prefer if the segment wasn't configurable same as before.

@gui1117 gui1117 added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D5-nicetohaveaudit ⚠️ PR contains trivial changes to logic that should be properly reviewed. labels Sep 21, 2021
@georgesdib
Copy link
Contributor Author

All companion errors should be fixed now, but not sure how to retrigger the checks without committing a dummy commit.

@georgesdib georgesdib requested a review from KiChjang September 22, 2021 21:30
@KiChjang
Copy link
Contributor

bot merge

@ghost
Copy link

ghost commented Sep 22, 2021

Error: Approval criteria was not satisfied.

The following errors might have affected the outcome of this attempt:

  • 'Benchmarking and Weights' does not match any projects in substrate's Process.json

Merge failed. Check out the criteria for merge.

@KiChjang
Copy link
Contributor

bot merge

@ghost
Copy link

ghost commented Sep 22, 2021

Trying merge.

@ghost ghost merged commit eded990 into paritytech:master Sep 22, 2021
@shawntabrizi
Copy link
Member

/tip small

@substrate-tip-bot
Copy link

Please fix the following problems before calling the tip bot again:

  • Contributor did not properly post their Polkadot or Kusama address. Make sure the pull request has: "{network} address: {address}".

@shawntabrizi
Copy link
Member

shawntabrizi commented Sep 23, 2021 •
edited
Loading

@georgesdib if you want to receive a tip, please add to your PR body something like:

polkadot address: <address>

@georgesdib georgesdib mentioned this pull request Sep 23, 2021
Merged
@georgesdib
Copy link
Contributor Author

@georgesdib if you want to receive a tip, please add to your PR body something like:

polkadot address:

Added, thank you very much for that!

@shawntabrizi
Copy link
Member

/tip small

@substrate-tip-bot
Copy link

A small tip was successfully submitted for georgesdib (141CVLM9W5NF4wc8fyMRnRW8dvQsfKQHjNxF6tRHJmPhZqVf on polkadot).

https://polkadot.js.org/apps/#/treasury/tips

This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gui1117 gui1117 gui1117 approved these changes

@KiChjang KiChjang KiChjang approved these changes

@andresilva andresilva Awaiting requested review from andresilva

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D5-nicetohaveaudit ⚠️ PR contains trivial changes to logic that should be properly reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@georgesdib @KiChjang @shawntabrizi @gui1117