Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Move as much code out of node into core as possible #750

Closed
3 of 8 tasks
gavofyork opened this issue Sep 16, 2018 · 3 comments
Closed
3 of 8 tasks

Move as much code out of node into core as possible #750

gavofyork opened this issue Sep 16, 2018 · 3 comments
Assignees
Labels
J1-meta A specific issue for grouping tasks or bugs of a specific category.
Milestone

Comments

@gavofyork
Copy link
Member

gavofyork commented Sep 16, 2018

This a meta-issue. Offenders:

  • node_consensus: Should be removed to core.
  • node_network: Should be removed to core.
  • node_transaction_pool: A general, runtime-pluggable transaction queue as in Generic Transaction Queue logic in runtime #728 should allow this to be eliminated.
  • node_api: The pub mod api { impl_stubs!( ... ) } should be able to be reused for creating an ergonomic calling interface in native code, thereby eliminating the need for most of the API boilerplate.
  • node_service: Looks pretty boilerplatey. Use macros and/or more generics in order to get it down to the essentials.
  • Runtime refactorings:
@gavofyork gavofyork added this to the 1.0 beta milestone Sep 16, 2018
@gavofyork gavofyork added the J1-meta A specific issue for grouping tasks or bugs of a specific category. label Sep 16, 2018
@bkchr
Copy link
Member

bkchr commented Sep 20, 2018

I'm started working on the consensus stuff.

@gavofyork
Copy link
Member Author

@gnunicorn & @bkchr could you check with each other that your changes don't collide? :)

@bkchr
Copy link
Member

bkchr commented Nov 26, 2018

@gavofyork I think this issue can be closed?

liuchengxu added a commit to chainx-org/substrate that referenced this issue Aug 23, 2021
* Add on_destroy_before()

The vote weight should be settled before applying the change of token balance.

Close paritytech#748

* Update wasm

* Add BTC intention profile in tests

* Nit
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
J1-meta A specific issue for grouping tasks or bugs of a specific category.
Projects
None yet
Development

No branches or pull requests

4 participants