Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Automatically impl deposit_event #920

Closed
gavofyork opened this issue Oct 17, 2018 · 3 comments · Fixed by #953
Closed

Automatically impl deposit_event #920

gavofyork opened this issue Oct 17, 2018 · 3 comments · Fixed by #953
Assignees
@bkchr
Labels
I7-refactor Code needs refactoring. Z1-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder
Milestone
1.0 beta

Comments

@gavofyork
Copy link
Member

The decl_module macro should automatically impl the deposit_event function. Right now it's manually implemented in each module which is boilerplatey.
@gavofyork gavofyork added I7-refactor Code needs refactoring. Z1-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder labels Oct 17, 2018
@gavofyork gavofyork added this to the 1.0 beta milestone Oct 17, 2018
@gavofyork gavofyork mentioned this issue Oct 19, 2018
Closed
8 tasks
@guanqun
Copy link

guanqun commented Oct 21, 2018

not all srml module implemented deposit_event, should we add a switch/flag in the decl_module to decide if we need to implement this function?

@gavofyork
Copy link
Member Author

yup.

@gavofyork
Copy link
Member Author

yes

@bkchr bkchr self-assigned this Oct 23, 2018
@bkchr bkchr mentioned this issue Oct 23, 2018
Merged
lamafab pushed a commit to lamafab/substrate that referenced this issue Jun 16, 2020
@gavofyork
Introduce progressive democracy (paritytech#920)
d0fbe6e 
* Updates for the new democracy

* Introduce progressive democracy

Also move to "master" branch of Substrate ready for continuous
sync with Substrate master.
liuchengxu added a commit to chainx-org/substrate that referenced this issue Aug 23, 2021
@atenjin @liuchengxu
Feature/add testchain confucianism (paritytech#921)
db37f5c 
* support confucianism testnet config

* Update bitcoin genesis for testnet confucianism (paritytech#920)

* Update bitcoin genesis for testnet confucianism

* Apply clippy (paritytech#919)

* Start applying clippy

* Pass clippy on src/main.rs

* Pass cli/src/lib.rs

* Pass clippy on cli/src/service.rs

* Pass clippy on cli/src/genesis_config/mod.rs

* Pass clippy on cli/src/genesis_config/chainx.rs

* Add clippy to CI

* Fix a bunch of clippy warnings

* Pass clippy on xbitcoin

* Pass clippy on xdex spot

* Try passing CI

* Fix more clippy warnings

* Add clippy_check GA

* Use actions-rs/cargo@v1

* Add clippy component

* Use stable toolchain

* .

* Add missing running time

* Suppress non-trivival clippy warnings

* .

* Fix CI

* Update btc genesis to most recent difficulty adjusted block

Co-authored-by: Aten <[email protected]>

Co-authored-by: Liu-Cheng Xu <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bkchr bkchr

Labels
I7-refactor Code needs refactoring. Z1-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder
Projects
None yet
Milestone
1.0 beta
Development

Successfully merging a pull request may close this issue.

Multiple improvements to the decl_module! macro paritytech/substrate
3 participants
@guanqun @gavofyork @bkchr