Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs suggestions. #33

Merged
merged 17 commits into from
Oct 6, 2023
Merged

Docs suggestions. #33

merged 17 commits into from
Oct 6, 2023

Conversation

RolandMacDoland
Copy link
Collaborator

Closes #32.

@RolandMacDoland RolandMacDoland added the documentation Improvements or additions to documentation label Oct 4, 2023
@RolandMacDoland RolandMacDoland self-assigned this Oct 4, 2023
@nmheim
Copy link
Collaborator

nmheim commented Oct 4, 2023

Are we sure that we caught all the changes from gitlab? the docs/docutils.py is missing here

@RolandMacDoland
Copy link
Collaborator Author

Are we sure that we caught all the changes from gitlab? the docs/docutils.py is missing here

It's weird because I've got it locally. But indeed, I've noticed it doesn't find it in CI. Let me fix this.

@vytautas-a vytautas-a mentioned this pull request Oct 6, 2023
Merged
madagra
madagra approved these changes Oct 6, 2023
View reviewed changes
Copy link
Collaborator

@madagra madagra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Roland-djee let's merge this one since there are other PRs on docs which are blocked otherwise.

@madagra madagra mentioned this pull request Oct 6, 2023
Merged
@RolandMacDoland
Copy link
Collaborator Author

RolandMacDoland commented Oct 6, 2023 •
edited
Loading

@Roland-djee let's merge this one since there are other PRs on docs which are blocked otherwise.

Why not merging them all together ?

And tbf @madagra today is my last shot at the docs. I won't be doing more. So it should be ready to be merged by then.

@RolandMacDoland RolandMacDoland merged commit 8e55e01 into main Oct 6, 2023
@RolandMacDoland RolandMacDoland deleted the rg/docs-reviews branch October 6, 2023 12:35
madagra pushed a commit that referenced this pull request Oct 10, 2023
@RolandMacDoland @awennersteen
@dominikandreasseitz @jpmoutinho @vytautas-a @nmheim @madagra
Documentation improvements (#33)
13ff802 
Co-authored-by: Aleksander Wennersteen <[email protected]>
Co-authored-by: Mario Dagrada <[email protected]>
Co-authored-by: Dominik Seitz <[email protected]>
Co-authored-by: Joao Moutinho <[email protected]>
Co-authored-by: Vytautas Abramavicius <[email protected]>
Co-authored-by: Niklas Heim <[email protected]>
Co-authored-by: Roland Guichard <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@madagra madagra madagra approved these changes

Assignees

@RolandMacDoland RolandMacDoland

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Docs review and improvements
5 participants
@RolandMacDoland @nmheim @madagra @jpmoutinho @vytautas-a