Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changing Pulser backend defaults and improved documentation #37

Merged
merged 8 commits into from
Oct 6, 2023
Merged

Changing Pulser backend defaults and improved documentation #37

merged 8 commits into from
Oct 6, 2023

Conversation

madagra
Copy link
Collaborator

@madagra madagra commented Oct 4, 2023 •
edited
Loading

WiP

Changes:

  • changed default max_duration to 4000 ns
  • changed default max_amplitude to 1.5 rad/us
  • changed default device to REALISTIC
  • improved documentation (work in progress)

@madagra madagra added the documentation Improvements or additions to documentation label Oct 4, 2023
@madagra madagra requested a review from kaosmicadei October 4, 2023 17:27
@madagra madagra self-assigned this Oct 4, 2023
@madagra madagra requested review from RolandMacDoland and kaosmicadei and removed request for kaosmicadei and RolandMacDoland October 6, 2023 07:29
@madagra
Copy link
Collaborator Author

madagra commented Oct 6, 2023

@Roland-djee @kaosmicadei this is ready for review.

vytautas-a
vytautas-a reviewed Oct 6, 2023
View reviewed changes
docs/digital_analog_qc/pulser-basic.md Outdated

| gate | description | trainable parameter |
|-------------|--------------------------------------------------------------------------------------------------|---------------------|
| `Rot` | Single qubit rotations. | rotation angle |
| `AnalogRot` | Span a single qubit rotation among the entire register. | rotation angle |
| `RX`, `RY`, `RZ` | Single qubit rotations. Notice that the interaction is on and this affects the resulting gate fidelity. | rotation angle |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, RZ is not supported now.

Copy link
Collaborator Author

@madagra madagra Oct 6, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True, I forgot to remove it. I can add it, though, it should be straightforward. What do you think @vytautas-a?

@vytautas-a
Copy link
Collaborator

This current pulser-basic.md is based on an old version that contains entanglement stuff that can't be pushed to main, as well as it doesn't have section on observables. I pushed the corresponding changes to #33

@madagra
Copy link
Collaborator Author

madagra commented Oct 6, 2023 •
edited
Loading

This current pulser-basic.md is based on an old version that contains entanglement stuff that can't be pushed to main, as well as it doesn't have section on observables. I pushed the corresponding changes to #33

We do not need a section on observables because they work the same way as the other backends. It would be just bloating the docs, imo.

@vytautas-a I will remove the entanglement from here as well. Notice that this MR improves the Pulser docs quite a lot and does also other stuff we agreed with @kaosmicadei & others. Let's merge first #33 and the this one?

@vytautas-a
Copy link
Collaborator

This current pulser-basic.md is based on an old version that contains entanglement stuff that can't be pushed to main, as well as it doesn't have section on observables. I pushed the corresponding changes to #33

We do not need a section on observables because they work the same way as the other backends. It would be just bloating the docs, imo.

Fair enough, but the entanglement sections except the very first one with Bell states have to go as well.

@RolandMacDoland RolandMacDoland merged commit 85c30fa into main Oct 6, 2023
@RolandMacDoland RolandMacDoland deleted the md/pulser_backend_changes branch October 6, 2023 12:58
madagra added a commit that referenced this pull request Oct 10, 2023
@madagra @RolandMacDoland
Changing Pulser backend defaults and improved documentation (#37)
7f13e3e 
* Improvements to the Pulser backend documents + change defaults
* Shorter names to the workflows
* Linting
* Improvements to the docs
* Added AnalogRZ operation to the enumeration
* Go back to idealized device

Co-authored-by: Roland Guichard <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vytautas-a vytautas-a vytautas-a left review comments

@kaosmicadei kaosmicadei Awaiting requested review from kaosmicadei

Assignees

@madagra madagra

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@madagra @vytautas-a @RolandMacDoland