feat(charts): Update Victory dependencies #7986
Conversation
dlabrecq
force-pushed
the
7614-victory-update
branch
from
96b0cdd to
0982333
Compare
|
Preview: https://patternfly-react-pr-7986.surge.sh A11y report: https://patternfly-react-pr-7986-a11y.surge.sh |
| @@ -34,24 +34,24 @@ exports[`ChartBulletQualitativeRange 1`] = ` | |||
| shape-rendering="auto" | |||
| style="stroke: var(--pf-chart-axis--tick--stroke--Color, #d2d2d2); fill: var(--pf-chart-axis--tick--Fill, transparent); size: 5px; stroke-linecap: round; stroke-linejoin: round; stroke-width: 1;" | |||
| vector-effect="non-scaling-stroke" | |||
| x1="50" | |||
| x2="50" | |||
| x1="225" | |||
There was a problem hiding this comment.
What do these values mean and why are they changed? Curious as I'm not seeing a data change.
There was a problem hiding this comment.
Looks like it might have something to do with a label being on the left of the chart (so like an offset) based on values I'm seeing while inspecting examples.. not sure why this snapshot was changed, but as the examples look good i'm not too worried
There was a problem hiding this comment.
These updates look related to the axis tick label.
Can't pinpoint the exact change between Victory v36.2.1 and v36.6.7. However, the bullet chart examples look good to me.
The change log can be found here
https://github.com/FormidableLabs/victory/blob/main/CHANGELOG.md
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
Update Victory dependencies to v36.6.7
Change log:
https://github.com/FormidableLabs/victory/blob/main/CHANGELOG.md
Closes #7614