Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ErrorArgumentParser override of _parse_known_args is incompatible with 3.12.7 #3266

Merged
merged 1 commit into from
Nov 9, 2024

Conversation

frostming
Copy link
Collaborator

Fixes #3264

Signed-off-by: Frost Ming [email protected]

Pull Request Checklist

  • A news fragment is added in news/ describing what is new.
  • Test cases added for changed code.

Describe what you have changed in this PR.

Copy link

codecov bot commented Nov 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.28%. Comparing base (88d947f) to head (d3d29f4).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3266   +/-   ##
=======================================
  Coverage   85.28%   85.28%           
=======================================
  Files         112      112           
  Lines       11375    11375           
  Branches     2478     2478           
=======================================
  Hits         9701     9701           
  Misses       1146     1146           
  Partials      528      528           
Flag Coverage Δ
unittests 85.08% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@frostming frostming merged commit ec0a2fe into main Nov 9, 2024
24 checks passed
@frostming frostming deleted the frostming/issue3264 branch November 9, 2024 08:17
didib pushed a commit to didib/pdm that referenced this pull request Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ErrorArgumentParser override of _parse_known_args is incompatible with 3.12.7
1 participant