Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added ocean, empire, and marinearea as supported types #75

Merged
merged 2 commits into from
Sep 20, 2017
Merged

added ocean, empire, and marinearea as supported types #75

merged 2 commits into from
Sep 20, 2017

Conversation

trescube
Copy link
Contributor

@trescube trescube commented Sep 8, 2017 •
edited
Loading

Adds ocean, empire, and marinearea so PiP can be even coarser.

@trescube trescube self-assigned this Sep 8, 2017
orangejulius
orangejulius approved these changes Sep 8, 2017
View reviewed changes
Copy link
Member

@orangejulius orangejulius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐬 💧 🐟 🌊

missinglink
missinglink approved these changes Sep 11, 2017
View reviewed changes
Copy link
Member

@missinglink missinglink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

{{ insert ocean pun here }}

@orangejulius orangejulius mentioned this pull request Sep 13, 2017
Merged
@trescube trescube changed the title added ocean and marinearea as supported types added ocean, empire, and marinearea as supported types Sep 13, 2017
@trescube trescube force-pushed the add-ocean-and-marine-area branch from 570d1a5 to 0bc90dc Compare September 19, 2017 19:43
dianashk
dianashk approved these changes Sep 19, 2017
View reviewed changes
Copy link
Contributor

@dianashk dianashk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

King Neptune approves this PR

@trescube trescube force-pushed the add-ocean-and-marine-area branch from 21f4834 to e27dc0c Compare September 20, 2017 14:18
@trescube trescube merged commit 4dd63b4 into master Sep 20, 2017
@ghost ghost removed the in review label Sep 20, 2017
@trescube trescube deleted the add-ocean-and-marine-area branch September 20, 2017 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orangejulius orangejulius orangejulius approved these changes

@missinglink missinglink missinglink approved these changes

@dianashk dianashk dianashk approved these changes

Assignees

@trescube trescube

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@trescube @orangejulius @missinglink @dianashk