Add more placetypes to download #280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
orangejulius
requested changes
Sep 13, 2017
| @@ -31,12 +31,15 @@ Currently, the supported hierarchy types are: | |||
| - county | |||
| - dependency | |||
| - disputed | |||
| - [empire](https://www.youtube.com/watch?v=-bzWSJG93P8) | |||
package.json
Outdated
| @@ -41,7 +41,7 @@ | |||
| "pelias-config": "2.12.0", | |||
| "pelias-dbclient": "2.2.2", | |||
| "pelias-logger": "0.2.0", | |||
| "pelias-model": "5.0.1", | |||
| "pelias-model": "pelias/model", | |||
There was a problem hiding this comment.
Oh you're probably waiting for this to be merged, right? pelias/model#75
There was a problem hiding this comment.
Correct, I'm stalling on merging that for a bit as I worked out how this effects the whole ecosystem.
trescube
force-pushed
the
add-more-placetypes-to-download
branch
4 times, most recently
from
23be0c5 to
06573ea
Compare
trescube
force-pushed
the
add-more-placetypes-to-download
branch
from
06573ea to
0f9ea52
Compare
orangejulius
approved these changes
Sep 21, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
empire,ocean, andmarineareato download. Also synthesizes a hierarchy from the id and placetype when no hierarchies are in the source data. This is useful for top-level placetypes like oceans that have no hierarchies. Without this, the ES document would not haveocean,ocean_id, andocean_awith is inconsistent with lower level placetypes like neighbourhoods where the hierarchy ensures thatneighbourhhood,neighbourhood_id, andneighbourhood_aare in the ES documents.