Add hyphen in pelias peliasNameTokenizer and peliasStreetTokenizer
#375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orangejulius
added a commit
to pelias/docker
that referenced
this pull request
Sep 9, 2019
orangejulius
added a commit
to pelias/acceptance-tests
that referenced
this pull request
Sep 12, 2019
Connects pelias/schema#301 Connects pelias/schema#375 Connects pelias/schema#65
This was referenced Sep 12, 2019
Open
|
Looks good in our testing and is definitely overdue for being merged :) Thanks for pushing it through! |
orangejulius
added a commit
to pelias/acceptance-tests
that referenced
this pull request
Sep 18, 2019
Connects pelias/schema#301 Connects pelias/schema#375 Connects pelias/schema#65
orangejulius
added a commit
to pelias/acceptance-tests
that referenced
this pull request
Sep 18, 2019
Connects pelias/schema#301 Connects pelias/schema#375 Connects pelias/schema#65
orangejulius
added a commit
that referenced
this pull request
Nov 7, 2019
The first error seen when trying to use our current schema with Elasticsearch 7 is: ``` [illegal_argument_exception] Token filter [word_delimiter] cannot be used to parse synonyms ``` The [word delimiter](https://www.elastic.co/guide/en/elasticsearch/reference/current/analysis-word-delimiter-tokenfilter.html) token filter is only used in one place: the `peliasAdmin` analyzer. Looking at the documentation for `word_delimiter`, it does _a lot_: splitting words, handling punctuation, and even some basic stemming. It really feels like an extremely broad tool and at this point feels like something that Elasticsearch would deprecate in the future. Furthermore, looking at our integration tests, it seems one of the key reasons we used it was to tokenize on hyphens, which we have done using the `peliasNameTokenizer` since #375. Considering how complicated this token filter is, and how it's now being used with relatively little effect, it seems like something we can remove. Connects pelias/pelias#831
orangejulius
added a commit
that referenced
this pull request
May 20, 2020
The first error seen when trying to use our current schema with Elasticsearch 7 is: ``` [illegal_argument_exception] Token filter [word_delimiter] cannot be used to parse synonyms ``` The [word delimiter](https://www.elastic.co/guide/en/elasticsearch/reference/current/analysis-word-delimiter-tokenfilter.html) token filter is only used in one place: the `peliasAdmin` analyzer. Looking at the documentation for `word_delimiter`, it does _a lot_: splitting words, handling punctuation, and even some basic stemming. It really feels like an extremely broad tool and at this point feels like something that Elasticsearch would deprecate in the future. Furthermore, looking at our integration tests, it seems one of the key reasons we used it was to tokenize on hyphens, which we have done using the `peliasNameTokenizer` since #375. Considering how complicated this token filter is, and how it's now being used with relatively little effect, it seems like something we can remove. Connects pelias/pelias#831
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👋 I did some awesome work for the Pelias project and would love for everyone to have a look at it and provide feedback ❤️.
Here's the reason for this change 🚀
Some streets are written with hyphen, such as
20 boulevard saint-germain, Paris, France. But when we write this street, we can omit the hyphen.With the current schema, if we search
20 boulevard saint germain, paris, francewe have no results. (This is the same issue for51 Friedrich-Richter-Straße)Here's what actually got changed 👏
I added the hyphen in
peliasNameTokenizerandpeliasStreetTokenizerto covert all analyzers.Here's how others can test the changes 👀
20 boulevard saint germain, paris, france20 boulevard saint germain, paris, france51 Friedrich-Richter-Straße51 Friedrich-Richter-Straße