feat(peliasAdmin): Remove word delimiter filter #392
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
|
While I've opened this PR now, I definitely don't want to merge this until ES6 work is pretty much wrapped up, to keep things simple. |
|
I think this filter is a relic from the past and it's function has long been forgotten to the ages. There are two valid solutions to this error:
I don't have any preconceived notions of which of those two is correct however I think it's important to have an archeological dig to understand the original intent before we remove it entirely. |
The first error seen when trying to use our current schema with Elasticsearch 7 is: ``` [illegal_argument_exception] Token filter [word_delimiter] cannot be used to parse synonyms ``` The [word delimiter](https://www.elastic.co/guide/en/elasticsearch/reference/current/analysis-word-delimiter-tokenfilter.html) token filter is only used in one place: the `peliasAdmin` analyzer. Looking at the documentation for `word_delimiter`, it does _a lot_: splitting words, handling punctuation, and even some basic stemming. It really feels like an extremely broad tool and at this point feels like something that Elasticsearch would deprecate in the future. Furthermore, looking at our integration tests, it seems one of the key reasons we used it was to tokenize on hyphens, which we have done using the `peliasNameTokenizer` since #375. Considering how complicated this token filter is, and how it's now being used with relatively little effect, it seems like something we can remove. Connects pelias/pelias#831
orangejulius
force-pushed
the
remove-word_delimiter
branch
from
4b5dcb4 to
5701484
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first error seen when trying to use our current schema with Elasticsearch 7 is:
The word delimiter token filter is only used in one place: the
peliasAdminanalyzer.Looking at the documentation, this token filter does a lot: splitting words, handling punctuation, and even some basic stemming.
It really feels like an extremely convoluted tool and at this point I have a suspicion it is something that Elasticsearch would deprecate in the future.
Furthermore, according to our integration tests, it seems one of the key reasons we used it was to tokenize on hyphens, which we have done using the
peliasNameTokenizersince #375.Considering how complicated this token filter is, and how it's now being used with relatively little effect, it seems like something we should remove.
Connects pelias/pelias#831