-
-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Evaluate PEX_ROOT cache structure. #1655
Comments
It turns out #1661 had to deal with 1 (versioning the |
I broke out #1662 for item 2 since that looks closeable. |
Previously Pex used Pip's `--target` scheme which had both known bugs (pypa/pip#7658) and unknown quirks that Pex was failing to fully be able to work around. Switch to the `--prefix` scheme which exactly mirrors the scheme venvs use so that venvs can be created with content of all sorts placed where it belongs. This removes fragile parsing and interpretation of the RECORD; now Pex only creates a RECORD, which is much more straight forward, when building a venv. Partially addresses #1655 by switching to sha256 for all external artifact hashing. Only internal hashing remains for: 1. `interpreters` / INTERP-INFO 2. `venvs` and `unzipped_pexes` / PEX-INFO pex_hash (but this is a hash that includes all distributions' sha256 hashes). Fixes #1656 Closes #1662
Item, 1 is now directly addressed with versioned cache entries like this: Lines 93 to 95 in 84a4196
Item 3 is mainly addressed with the |
There are a few things to evaluate:
The text was updated successfully, but these errors were encountered: