Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pfSense-pkg-RRD_Summary - Rewrite to include display of historical data #475

Merged
merged 1 commit into from
Jan 17, 2018
Merged

pfSense-pkg-RRD_Summary - Rewrite to include display of historical data #475

merged 1 commit into from
Jan 17, 2018
+118 −48

Conversation

shonjir
Copy link
Contributor

@shonjir shonjir commented Nov 6, 2017

Rewrite of RRD Summary package to allow display of available historical data beyond current and previous month. Bumped the major version because of the significant changes.

This is my first attempt at a pfSense package, please be gentle :)

@shonjir shonjir changed the title Rewrite to include display of historical data pfSense-pkg-RRD_Summary - Rewrite to include display of historical data Nov 12, 2017
@shonjir
Copy link
Contributor Author

shonjir commented Nov 15, 2017

Screenshot of new display:
rrd screenshot

sbeaver-netgate
sbeaver-netgate reviewed Dec 5, 2017
View reviewed changes
sysutils/pfSense-pkg-RRD_Summary/files/usr/local/www/status_rrd_summary.php Outdated
<td><?=sprintf("%0.2f %s", $data["total_in"], $u[$units]); ?></td>
<td><?=sprintf("%0.2f %s", $data["total_out"], $u[$units]); ?></td>
<td><?=sprintf("%0.2f %s", $data["total_in"] + $data["total_out"], $u[$units]); ?></td>
</tr>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indenting looks excessive

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, but felt it was better to preserve the original indenting than fix it here. Indenting is fixable, let me know if you'd like me to fix it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes please. It is good to take the opportunity to fix things like this and get the codebase as consistent as possible :) Nice changes BTW.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Will make the changes. Would you like me to squash the commit?

@shonjir
Copy link
Contributor Author

shonjir commented Dec 5, 2017

@sbeaver-netgate - indentation ought to be ok now.

rbgarga
rbgarga requested changes Dec 6, 2017
View reviewed changes
sysutils/pfSense-pkg-RRD_Summary/Makefile Outdated
PORTVERSION= 1.3.2
PORTREVISION= 2
PORTVERSION= 2.0
PORTREVISION= 1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When PORTVERSION changes, PORTREVISION line must be removed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@shonjir
Rewrite to include display of historical data

Verified

This commit was signed with the committer’s verified signature. The key has expired.
davidor David Ortiz
GPG key ID: DAA78F877C2976B8
Expired
Verified
Learn about vigilant mode
20db740
@shonjir
Copy link
Contributor Author

shonjir commented Dec 6, 2017

@rbgarga - PORTREVISION removed as requested.

@jim-p
Copy link
Contributor

jim-p commented Dec 11, 2017

In an effort to improve the tracking of changes and bug/feature requests, we have decided to require an entry on the pfSense Redmine issue tracker associated with every pull request, and likewise the Redmine entry should also have a link back to the pull request.

If you could, please associate this PR to a Redmine issue either by locating an existing issue at https://redmine.pfsense.org or by creating a new issue. Add a link to the Redmine issue that points to this PR, and also add a link on the PR to the Redmine issue.

For more information, see https://doc.pfsense.org/index.php/Submitting_a_Pull_Request_via_Github

Thanks!

@shonjir
Copy link
Contributor Author

shonjir commented Dec 11, 2017

Created feature issue https://redmine.pfsense.org/issues/8190.

shonjir
shonjir commented Dec 14, 2017
View reviewed changes
sysutils/pfSense-pkg-RRD_Summary/Makefile
@@ -1,8 +1,7 @@
# $FreeBSD$

PORTNAME= pfSense-pkg-RRD_Summary
PORTVERSION= 1.3.2
PORTREVISION= 2
PORTVERSION= 2.0
CATEGORIES= sysutils
Copy link
Contributor Author

@shonjir shonjir Dec 14, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed PORTREVISION as requested by @rbgarga

@shonjir
Copy link
Contributor Author

shonjir commented Dec 27, 2017 •
edited
Loading

@rbgarga - Not sure what changes are still outstanding - I made the requested changes. Is there anything else?

@netgate-git-updates netgate-git-updates merged commit 20db740 into pfsense:devel Jan 17, 2018
netgate-git-updates pushed a commit that referenced this pull request Jan 17, 2018
@rbgarga
Merge pull request #475 from shonjir/rrd

Verified

This commit was signed with the committer’s verified signature. The key has expired.
davidor David Ortiz
GPG key ID: DAA78F877C2976B8
Expired
Verified
Learn about vigilant mode
26761fa
netgate-git-updates pushed a commit that referenced this pull request Apr 23, 2021
@rosorio
audio/ncspot: upgrade to v0.6.0 from v0.3.0

Verified

This commit was signed with the committer’s verified signature. The key has expired.
davidor David Ortiz
GPG key ID: DAA78F877C2976B8
Expired
Verified
Learn about vigilant mode
84ec73e 
    v0.6.0  https://github.com/hrkfdn/ncspot/releases/tag/v0.6.0
            Refactorings + dependency updates
            Sort artist albums by year
            Store user state in binary CBOR format
            Improve synchronization of playback times
            Implement track preloading
            Don't save tracks AND album when saving an album (#488)
            (Re)store currently playing track + shuffle state from previous session (#448)
            Show display name owning the current library (#470)
            Add logout command (#470)
            Pagination for artist albums (#477)
            Split artist albums/singles into separate panel
            Play top tracks by artist instead of all tracks by artist
            Pagination for Podcast episodes
            Show tracks + duration of album, playlist, queue in the title bar (#475)

    v0.5.0  https://github.com/hrkfdn/ncspot/releases/tag/v0.5.0
            Fix: correct positioning of search match highlight
            Improve album loading in artist view (#446)
            Fix display of PlayNext command (#445)
            More resilient playlist track deletion (f2bcfca)
            Remove plain-text credential store (#447)
            Clear search term when ESC is pressed (#384)
            Loop mode is now editable via MPRIS (#437)
            Persist sorting orders for playlists (#436)
            Persist volume and shuffle/repeat state across app restarts (#438)
            Persist track queue across app restarts (#438)
            Add config values to override shuffle/repeat state
            Implement cover drawing as optional feature (#451)

    v0.4.0 https://github.com/hrkfdn/ncspot/releases/tag/v0.4.0
            Fix multiple tracks in queue being shown as playing (#396)
            Return to search when viewing search results (#397)
            Add support for open.spotify.com links (#392)
            Restart queue if pressing play when stopped (#399)
            Fix not handling changed event (#402)
            Don't handle FinishedTrack as Stopped (#403)
            Fix removing listview item even if not succesfully deleted (#404)
            Open search results in search screen (#413)
            CI: Publish binary artifacts on release (#393)
            Add simple debian-packaging with cargo-deb (#405)
netgate-git-updates pushed a commit that referenced this pull request Feb 4, 2023
@fraggerfox
www/jira-cli: Update to 1.3.0
7cafb03 
Changes since 1.1.0:

v1.3.0

This release contains some features and enhancements + upgrades all
dependencies.

- feat: Allow to set reporter on issue create by @ankitpokhrel in #539
- feat: Use single char ellipsis instead of triple dot by @ankitpokhrel in #540
- ehc: Make assignee operation atomic on create by @ankitpokhrel in #531
- ehc: Auto fallback to plain output on notty by @ankitpokhrel in #538
- ehc: Add warning for invalid custom field by @ankitpokhrel in #528 (Original work by @martinpovolny on #525)
- fix(build): Invalid commit hash in docker image by @ankitpokhrel in #535

- dep: Upgrade all packages by @ankitpokhrel in #532
- dep: Upgrade golang to v1.19 by @ankitpokhrel in #534
- ci: Upgrade golangci-lint to v1.50.1 by @ankitpokhrel in #536

Full Changelog: ankitpokhrel/jira-cli@v1.2.0...v1.3.0

v1.2.0

This release adds support for Jira v9, a serverinfo command to quickly check
your Jira server build info, lets you set resolution, assignee and comment on
issue move, and many more.

- feat: Add serverinfo command by @ankitpokhrel in #440
- feat: Support for Jira v9 by @ankitpokhrel in #447
- feat: Allow to set start datetime on worklog add by @ankitpokhrel in #453
- feat: Make date time input in worklog flexible by @ankitpokhrel in #465
- feat: Add support for project datatype in custom fields by @oveaurs in #482
- feat: Add weblink to issue (#446) by @Syd7 in #483
- feat: Resolution, assignee & comment on issue move by @ankitpokhrel in #492
- feat: Filter issues by the absence of label(s) by @martinpovolny in #505
- feat: Add labels to the issue listing by @martinpovolny in #506
- feat: Allow setting of fixed columns in the list of issues, epics and sprints
  by @martinpovolny in #509

- fix: Option to show issues from all projects in sprint list by @ankitpokhrel
  in #475
- fix: Discrepancy in --insecure flag by @ankitpokhrel in #507
- fix: Make board selection optional by @ankitpokhrel in #502
- fix: Improve support for pager by @ankitpokhrel in #503
- fix: Respect editor env vars in Windows by @ankitpokhrel in #524

- ci: Multi-arch docker image by @ankitpokhrel in #508
- doc: Add link to project in help by @ankitpokhrel in #456
- doc: Add Nix package by @bryanasdev000 in #458
- doc: Update help for completion cmd by @ankitpokhrel in #491
- doc: Add scoop installation process by @alkuzad in #497

- @bryanasdev000 made their first contribution in #458
- @oveaurs made their first contribution in #482
- @Syd7 made their first contribution in #483
- @alkuzad made their first contribution in #497
- @martinpovolny made their first contribution in #505

Full Changelog: ankitpokhrel/jira-cli@v1.1.0...v1.2.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbeaver-netgate sbeaver-netgate

@rbgarga rbgarga

@jim-p jim-p

@jdillard jdillard

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@shonjir @jim-p @rbgarga @jdillard @sbeaver-netgate @netgate-git-updates