Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pfSense-pkg-suricata: Extended eve output selectable headers #488

Conversation

securitym0nkey
Copy link
Contributor

This PR adds the functionality to configure the logged http headers and smtp fields in extended eve output.

This might be helpful if one wants to reduce the log output for various reasons. For example the logging of the Authorization header could leak login credentials. At the moment all HTTP headers are logged if extended http logging is enabled.

@securitym0nkey
Copy link
Contributor Author

Redmine issue 8203

@rbgarga
Copy link
Member

rbgarga commented Jan 12, 2018

@bmeeks8 can you please take a look at this change?

@bmeeks8
Copy link
Contributor

bmeeks8 commented Jan 12, 2018

These changes are OK with me. It might be easier to just merge them into the just pushed 4.0.3 GUI package so that we show only a single update to 4.0.3 for users. But I'm also fine with issuing a 4.0.3_1 version if you had rather do that.

Bill

@rbgarga
Copy link
Member

rbgarga commented Jan 12, 2018

4.0.3 was already merged.

@securitym0nkey please rebase your fork and adjust Makefile to become 4.0.3_1

@bmeeks8
Copy link
Contributor

bmeeks8 commented Jan 12, 2018

@securitym0nkey:

Would you mind also including this fix in this pull request?

Remove this line (line number 220) from the /usr/local/pkg/suricata/suricata_yaml_template.inc file. It is a deprecated parameter as of version 4.0.3 and causes log spam when Suricata starts up.

max-sessions: {$stream_max_sessions}

Thanks,
Bill

@securitym0nkey
Copy link
Contributor Author

@bmeeks8

sure, no problem i will include that fix when i do the rebase. maybe tomorrow if i find some time ;)

@bmeeks8
Copy link
Contributor

bmeeks8 commented Jan 12, 2018

Thanks!

@securitym0nkey securitym0nkey force-pushed the suricata-extended-eve-output-selectable-headers branch from f7253c1 to 94ac958 Compare January 14, 2018 12:52
@securitym0nkey
Copy link
Contributor Author

rebase done

@netgate-git-updates netgate-git-updates merged commit 94ac958 into pfsense:devel Jan 17, 2018
netgate-git-updates pushed a commit that referenced this pull request Jan 17, 2018
netgate-git-updates pushed a commit that referenced this pull request Apr 23, 2021
    v0.6.0  https://github.com/hrkfdn/ncspot/releases/tag/v0.6.0
            Refactorings + dependency updates
            Sort artist albums by year
            Store user state in binary CBOR format
            Improve synchronization of playback times
            Implement track preloading
            Don't save tracks AND album when saving an album (#488)
            (Re)store currently playing track + shuffle state from previous session (#448)
            Show display name owning the current library (#470)
            Add logout command (#470)
            Pagination for artist albums (#477)
            Split artist albums/singles into separate panel
            Play top tracks by artist instead of all tracks by artist
            Pagination for Podcast episodes
            Show tracks + duration of album, playlist, queue in the title bar (#475)

    v0.5.0  https://github.com/hrkfdn/ncspot/releases/tag/v0.5.0
            Fix: correct positioning of search match highlight
            Improve album loading in artist view (#446)
            Fix display of PlayNext command (#445)
            More resilient playlist track deletion (f2bcfca)
            Remove plain-text credential store (#447)
            Clear search term when ESC is pressed (#384)
            Loop mode is now editable via MPRIS (#437)
            Persist sorting orders for playlists (#436)
            Persist volume and shuffle/repeat state across app restarts (#438)
            Persist track queue across app restarts (#438)
            Add config values to override shuffle/repeat state
            Implement cover drawing as optional feature (#451)

    v0.4.0 https://github.com/hrkfdn/ncspot/releases/tag/v0.4.0
            Fix multiple tracks in queue being shown as playing (#396)
            Return to search when viewing search results (#397)
            Add support for open.spotify.com links (#392)
            Restart queue if pressing play when stopped (#399)
            Fix not handling changed event (#402)
            Don't handle FinishedTrack as Stopped (#403)
            Fix removing listview item even if not succesfully deleted (#404)
            Open search results in search screen (#413)
            CI: Publish binary artifacts on release (#393)
            Add simple debian-packaging with cargo-deb (#405)
netgate-git-updates pushed a commit that referenced this pull request Jun 9, 2022
ChangeLog: https://github.com/lldpd/lldpd/releases/tag/1.0.14

Changes
 * Add configure commands to alter inventory TLVs (#508)
Fix:
 * Update seccomp rules for newer kernel/libc (#488)
 * Correctly handle an interface whose index has changed (#490)
 * Don't send VLANs when there are too many (#501)

PR:	264355
Reported by:	[email protected]
Approved by:	[email protected] (maintainer)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants