Document new PDO classes and methods #4115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kamil-tekiela
requested changes
Nov 21, 2024
Girgias
force-pushed
the
pdo-new-8.4
branch
2 times, most recently
from
2c9ff06 to
c65251d
Compare
|
@sim1984 you are probably the best person to review the FireBird changes, I took some of the wording for the attributes (based on Saki's initial text) from https://ib-aid.com/articles/php-8-4-improvements-when-working-with-modern-firebird-versions |
|
@KentarouTakeda could you have a look at the |
There was a problem hiding this comment.
@Girgias
I tried to write as best as I could.
Please note that my use of English and xml syntax may not be very good in some places.
Girgias
commented
Nov 24, 2024
|
@kamil-tekiela can you review the |
kamil-tekiela
requested changes
Dec 1, 2024
Co-authored-by: KentarouTakeda <[email protected]>
Co-authored-by: Kamil Tekiela <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference: https://wiki.php.net/rfc/pdo_driver_specific_subclasses and https://wiki.php.net/rfc/pdo_driver_specific_parsers
Still needs MySQLi, PGSQL, and OCI8 (although that one is going to be low priority)
@SakiTakamachi can you document, either as inline comments or in a follow-up PR the transaction attributes?