-
Notifications
You must be signed in to change notification settings - Fork 757
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename folder that contain overloaded PDO methods #4288
Conversation
Thanks. I was almost at my wits end with these renames. I only found out a few minutes ago that this also is affected by file-entities. I merge doc-base first. This may need a heads uip on all translations, as it probally will break all (and also futher confuse translations that are done on Windows) |
I can take care of translations, just let me know. |
I will merge others idempotent first. And I just fixed building on Windows (at least on my machine), so will be possible to start from a building state. As bad this error can be, it' 20 somewhat old situation... It's maybe better to wait for 8.4 changes sloes down. |
Confirmed that changes merged today builds ok CI and Windows. So it's possible to start building state, in principle.
I ask to wait for next week, to allow a cooldown for big changes merged today (doc-base 201/202) and one planned for Thursday (doc-base 198). And to allow translations recover from Starting next week, please, take care of translations. I can't even imagine how many man-years were wasted dealing with the problems caused by these similarly named folders. |
The new Arguably, this is a PHP 8.4 related change. |
Ah, I was remembering, rather vividly, when a similar thing happened back in PHP 5 days. Since these are new, this explains something I wasn't able to understand: how file-entities, old or new, would be able to generate different names for paths that don't exist in Windows. I only managed to make the manual compilable on Windows with this ugly hack, already scheduled to be removed in an issue. |
* php/doc-en#4288 を反映(PDOのディレクトリ構成変更) * php/doc-en#4298 を反映(不要セクションの削除) * Update EN-Revision * php/doc-en#4330 を反映(PDOの階層構造の変更)
@alfsb this should fix the issue