Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename folder that contain overloaded PDO methods #4288

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

Girgias
Copy link
Member

@Girgias Girgias commented Dec 10, 2024

@alfsb this should fix the issue

@Girgias Girgias linked an issue Dec 10, 2024 that may be closed by this pull request
@alfsb
Copy link
Member

alfsb commented Dec 10, 2024

Thanks. I was almost at my wits end with these renames. I only found out a few minutes ago that this also is affected by file-entities. I merge doc-base first.

This may need a heads uip on all translations, as it probally will break all (and also futher confuse translations that are done on Windows)

@Girgias
Copy link
Member Author

Girgias commented Dec 10, 2024

I can take care of translations, just let me know.

@alfsb
Copy link
Member

alfsb commented Dec 10, 2024

I will merge others idempotent first. And I just fixed building on Windows (at least on my machine), so will be possible to start from a building state.

As bad this error can be, it' 20 somewhat old situation... It's maybe better to wait for 8.4 changes sloes down.

@alfsb
Copy link
Member

alfsb commented Dec 10, 2024

Confirmed that changes merged today builds ok CI and Windows. So it's possible to start building state, in principle.

I can take care of translations, just let me know.

I ask to wait for next week, to allow a cooldown for big changes merged today (doc-base 201/202) and one planned for Thursday (doc-base 198). And to allow translations recover from reference.spl.entities.countable. I will do some tests in the meanwhile.

Starting next week, please, take care of translations. I can't even imagine how many man-years were wasted dealing with the problems caused by these similarly named folders.

@Girgias
Copy link
Member Author

Girgias commented Dec 10, 2024

Confirmed that changes merged today builds ok CI and Windows. So it's possible to start building state, in principle.

I can take care of translations, just let me know.

I ask to wait for next week, to allow a cooldown for big changes merged today (doc-base 201/202) and one planned for Thursday (doc-base 198). And to allow translations recover from reference.spl.entities.countable. I will do some tests in the meanwhile.

Starting next week, please, take care of translations. I can't even imagine how many man-years were wasted dealing with the problems caused by these similarly named folders.

The new pdo sub folders got introduced with #4115 so it is not an old thing. And I was aware of the potential Windows issues, but to have things in a namespace and gen_stub not complain it needed to be in pdo/.

Arguably, this is a PHP 8.4 related change.

@alfsb
Copy link
Member

alfsb commented Dec 11, 2024

Arguably, this is a PHP 8.4 related change.

Ah, I was remembering, rather vividly, when a similar thing happened back in PHP 5 days. Since these are new, this explains something I wasn't able to understand: how file-entities, old or new, would be able to generate different names for paths that don't exist in Windows.

I only managed to make the manual compilable on Windows with this ugly hack, already scheduled to be removed in an issue.

@Girgias Girgias merged commit 1993c38 into php:master Dec 12, 2024
2 checks passed
@Girgias Girgias deleted the pdo-not-case-sensitive branch December 12, 2024 08:25
takaram added a commit to takaram/doc-ja that referenced this pull request Dec 30, 2024
KentarouTakeda pushed a commit to php/doc-ja that referenced this pull request Dec 31, 2024
* php/doc-en#4288 を反映(PDOのディレクトリ構成変更)

* php/doc-en#4298 を反映(不要セクションの削除)

* Update EN-Revision

* php/doc-en#4330 を反映(PDOの階層構造の変更)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Idempotent build: PDO/pdo
2 participants