Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Since twig/twig 3.15: Instantiating "Twig\Node\Node" directly is deprecated; the class will become abstract in 4.0. #16

Closed
liviuconcioiu opened this issue Dec 9, 2024 · 7 comments · Fixed by #18
Closed

Since twig/twig 3.15: Instantiating "Twig\Node\Node" directly is deprecated; the class will become abstract in 4.0. #16

liviuconcioiu opened this issue Dec 9, 2024 · 7 comments · Fixed by #18
Assignees
@williamdes
Labels
bug Something isn't working

Comments

@liviuconcioiu
Copy link
Contributor

liviuconcioiu commented Dec 9, 2024 •
edited
Loading

Describe the bug

Since twig/twig 3.15: Instantiating "Twig\Node\Node" directly is deprecated; the class will become abstract in 4.0.

To Reproduce

Steps to reproduce the behavior:

  1. Install from composer
  2. Remove the tmp/twig folder if exists
  3. Login to phpMyAdmin
  4. See error

Expected behavior

No deprecated messages should be shown.

Screenshots

deprecated

Server configuration

  • phpMyAdmin version: 5.2.2-dev, 6.0.0-dev

Additional context

twig/twig (v3.16.0)
twig/twig (v3.17.0)
@kamil-tekiela
Copy link

I don't think we do that in the codebase, except maybe in some tests.

@liviuconcioiu
Copy link
Contributor Author

The message is there... on 6.0.0-dev there are no issues.

@liviuconcioiu liviuconcioiu mentioned this issue Dec 11, 2024
Closed
@liviuconcioiu
Copy link
Contributor Author

@kamil-tekiela as you can see, now database names don't show up. They show only if databases are grouped by prefix.

bug

@liviuconcioiu
Copy link
Contributor Author

liviuconcioiu commented Dec 11, 2024 •
edited
Loading

Database names, table names, index names are missing. Only column names seems to be visible.

@shinsenter
Copy link

Same problem with twig/twig:3.17.0. Reported here phpmyadmin/phpmyadmin#19445.

@williamdes williamdes added the bug Something isn't working label Dec 16, 2024
@williamdes
Copy link
Member

@MauricioFauth I think this is blocking the release of 5.2.2
Else we force downgrade the version of twig ?

@williamdes
Copy link
Member

I am looking into it
Due to twigphp/Twig@8b27898

@williamdes williamdes transferred this issue from phpmyadmin/phpmyadmin Jan 7, 2025
@williamdes williamdes mentioned this issue Jan 7, 2025
Merged
williamdes added a commit that referenced this issue Jan 7, 2025
@williamdes
Merge #18 - Fix deprecations from Twig
4fae79a 
Pull-request: #18
Fixes: #17
Fixes: #16
Signed-off-by: William Desportes <[email protected]>
williamdes added a commit that referenced this issue Jan 7, 2025
@williamdes
Add a CHANGELOG entry for #16 and #17
ebe4001
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@williamdes williamdes

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix deprecations from Twig williamdes/twig-i18n-extension
5 participants
@MauricioFauth @shinsenter @kamil-tekiela @williamdes @liviuconcioiu