Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix deprecations from Twig #18

Merged
merged 4 commits into from
Jan 7, 2025
Merged

Fix deprecations from Twig #18

merged 4 commits into from
Jan 7, 2025

Conversation

williamdes
Copy link
Member

Fixes #17
Fixes #16

@williamdes
Fix #16 - Direct use of Node is deprecated
cb9fd67
@williamdes
Drop support for Twig < 3.17.0
ddbf44a 
Last release to have new deprecation warnings
@williamdes
Fix #17 - Replace Twig\Node\Expression\NameExpression and `Twig\Nod…
cd2a03a 
…e\Expression\TempNameExpression` are deprecated
@williamdes williamdes self-assigned this Jan 7, 2025
@MauricioFauth
Copy link
Member

Are you planning to release a 5.0 version of this package to use in phpMyAdmin 5.2? As this package is not used anymore in phpMyAdmin 6.0.

@williamdes
Copy link
Member Author

Are you planning to release a 5.0 version of this package to use in phpMyAdmin 5.2? As this package is not used anymore in phpMyAdmin 6.0.

That could do the work, for me a minor version is okay too.
What about you, why a major version ?

@williamdes williamdes merged commit 4fae79a into phpmyadmin:master Jan 7, 2025
5 of 6 checks passed
@williamdes williamdes deleted the deprecation-fixes branch January 7, 2025 21:46
@williamdes williamdes added the bug Something isn't working label Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MauricioFauth MauricioFauth MauricioFauth approved these changes

Assignees

@williamdes williamdes

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
2 participants
@williamdes @MauricioFauth