Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

go.mod: update most dependencies to latest versions #158

Merged
merged 1 commit into from
May 27, 2019
Merged

go.mod: update most dependencies to latest versions #158

merged 1 commit into from
May 27, 2019

Conversation

kennytm
Copy link
Contributor

@kennytm kennytm commented May 24, 2019 •
edited
Loading

What problem does this PR solve?

Update go.mod.

What is changed and how it works?

Update go.mod, in particular:

Cannot update failpoint since it needs a matching failpoint-ctl version.

Cannot update grpc, maybe caused by grpc/grpc-go#2636 (TracerTestSuite.TestCollectSyncerEvent will fail with "failed to connect rpc port for 100 retries in every 10ms")

Check List

Tests

  • Unit test

Code changes

Side effects

Related changes

@codecov
Copy link

codecov bot commented May 24, 2019

Codecov Report

Merging #158 into master will increase coverage by 0.0294%.
The diff coverage is n/a.

@@               Coverage Diff                @@
##             master       #158        +/-   ##
================================================
+ Coverage   34.2082%   34.2376%   +0.0294%     
================================================
  Files           121        121                
  Lines         13602      13602                
================================================
+ Hits           4653       4657         +4     
+ Misses         8420       8414         -6     
- Partials        529        531         +2

@kennytm kennytm marked this pull request as ready for review May 24, 2019 16:46
@kennytm kennytm requested a review from csuzhangxc May 24, 2019 16:46
csuzhangxc
csuzhangxc reviewed May 25, 2019
View reviewed changes
Copy link
Member

@csuzhangxc csuzhangxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@csuzhangxc csuzhangxc added priority/normal Minor change, requires approval from ≥1 primary reviewer status/LGT1 One reviewer already commented LGTM type/feature New feature labels May 25, 2019
@csuzhangxc
Copy link
Member

@amyangfei PTAL

@kennytm kennytm changed the title go.mod: update all dependencies to latest versions go.mod: update most dependencies to latest versions May 25, 2019
amyangfei
amyangfei approved these changes May 27, 2019
View reviewed changes
Copy link
Contributor

@amyangfei amyangfei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amyangfei amyangfei added status/LGT2 Two reviewers already commented LGTM, ready for merge and removed status/LGT1 One reviewer already commented LGTM labels May 27, 2019
@amyangfei amyangfei merged commit f04a93f into pingcap:master May 27, 2019
@kennytm kennytm deleted the update-go-mod branch May 27, 2019 02:30
@kennytm kennytm mentioned this pull request May 27, 2019
Merged
lichunzhu pushed a commit to lichunzhu/dm that referenced this pull request Apr 6, 2020
@kennytm @amyangfei
go.mod: update most dependencies to latest versions (pingcap#158)
2ca02d8
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@csuzhangxc csuzhangxc csuzhangxc left review comments

@amyangfei amyangfei amyangfei approved these changes

Assignees
No one assigned
Labels
priority/normal Minor change, requires approval from ≥1 primary reviewer status/LGT2 Two reviewers already commented LGTM, ready for merge type/feature New feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kennytm @csuzhangxc @amyangfei