Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dev/reference/tools/dm: support new column-mapping syntax #1166

Merged
merged 5 commits into from
May 30, 2019
Merged

dev/reference/tools/dm: support new column-mapping syntax #1166

merged 5 commits into from
May 30, 2019

Conversation

kennytm
Copy link
Contributor

@kennytm kennytm commented May 22, 2019

Update documents to include pingcap/tidb-tools#236.

@kennytm kennytm mentioned this pull request May 22, 2019
Merged
@kennytm
Copy link
Contributor Author

kennytm commented May 22, 2019

PTAL @csuzhangxc @CaitinChen

csuzhangxc
csuzhangxc reviewed May 24, 2019
View reviewed changes
Copy link
Member

@csuzhangxc csuzhangxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest LGTM

dev/reference/tools/data-migration/features/overview.md Show resolved Hide resolved
csuzhangxc
csuzhangxc reviewed May 24, 2019
View reviewed changes
Copy link
Member

@csuzhangxc csuzhangxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool! LGTM.
needing to update the go.mod of DM before merging this PR.

@kennytm kennytm mentioned this pull request May 24, 2019
Merged
@kennytm
Copy link
Contributor Author

kennytm commented May 27, 2019

pingcap/dm#158 is merged.

@csuzhangxc
Copy link
Member

@lilin90 PTAL

@lilin90 lilin90 requested review from CaitinChen and yikeke and removed request for CaitinChen May 28, 2019 04:08
yikeke
yikeke reviewed May 30, 2019
View reviewed changes
Copy link
Contributor

@yikeke yikeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

dev/reference/tools/data-migration/features/overview.md Outdated Show resolved Hide resolved
dev/reference/tools/data-migration/features/overview.md Outdated Show resolved Hide resolved
yikeke
yikeke approved these changes May 30, 2019
View reviewed changes
Copy link
Contributor

@yikeke yikeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kennytm kennytm merged commit 2393e83 into master May 30, 2019
@kennytm kennytm deleted the kennytm/dm-support-column-mapping-separator branch May 30, 2019 06:33
yikeke pushed a commit to yikeke/docs-cn that referenced this pull request Jun 3, 2019
dev/reference/tools/dm: update the column-mapping syntax
0f90b00 
Via: pingcap/docs#1166 PTAL
@yikeke yikeke mentioned this pull request Jun 3, 2019
Merged
lilin90 pushed a commit to pingcap/docs-cn that referenced this pull request Jun 5, 2019
@yikeke @lilin90
dev/reference/tools/dm: update the column-mapping syntax (#1391)
64a7850 
* dev/reference/tools/dm: update the column-mapping syntax

Via: pingcap/docs#1166 PTAL

* update punctuation

* change all "bit" and "bits" into "比特位"

* address comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csuzhangxc csuzhangxc csuzhangxc left review comments

@yikeke yikeke yikeke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kennytm @csuzhangxc @yikeke