Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Add description on admin pause ddl jobs and admin resume ddl jobs" #14078

Merged
merged 4 commits into from
May 30, 2023
Merged

Revert "Add description on admin pause ddl jobs and admin resume ddl jobs" #14078

merged 4 commits into from
May 30, 2023

Conversation

Oreoxmt
Copy link
Collaborator

@Oreoxmt Oreoxmt commented May 30, 2023 •
edited
Loading

Reverts #13731

Remove ADMIN PAUSE DDL JOBS job_id [, job_id] and ADMIN RESUME DDL JOBS job_id [, job_id] in TiDB v7.1.0

@ti-chi-bot
Copy link

ti-chi-bot bot commented May 30, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • ran-huang

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 30, 2023
@Oreoxmt Oreoxmt added the needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. label May 30, 2023
@Oreoxmt Oreoxmt requested review from Benjamin2037 and benmaoer May 30, 2023 04:34
@Oreoxmt Oreoxmt added the translation/doing This PR’s assignee is translating this PR. label May 30, 2023
@ti-chi-bot ti-chi-bot bot removed the missing-translation-status This PR does not have translation status info. label May 30, 2023
Oreoxmt
Oreoxmt commented May 30, 2023
View reviewed changes
ddl-introduction.md Outdated Show resolved Hide resolved
@Oreoxmt Oreoxmt mentioned this pull request May 30, 2023
Merged
@Oreoxmt Oreoxmt requested a review from ran-huang May 30, 2023 04:38
@Oreoxmt Oreoxmt self-assigned this May 30, 2023
@Oreoxmt Oreoxmt added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels May 30, 2023
@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 30, 2023
Benjamin2037
Benjamin2037 approved these changes May 30, 2023
View reviewed changes
Copy link
Contributor

@Benjamin2037 Benjamin2037 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

benmaoer
benmaoer approved these changes May 30, 2023
View reviewed changes
Copy link
Contributor

@benmaoer benmaoer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Oreoxmt
Copy link
Collaborator Author

Oreoxmt commented May 30, 2023

/remove-status LGT1
/status LGT2
/merge

@ti-chi-bot ti-chi-bot bot added the status/LGT2 Indicates that a PR has LGTM 2. label May 30, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented May 30, 2023

This pull request has been accepted and is ready to merge.

Commit hash: d499e56

@ti-chi-bot ti-chi-bot bot added status/can-merge Indicates a PR has been approved by a committer. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 30, 2023
@ti-chi-bot ti-chi-bot bot merged commit 4de2bdd into master May 30, 2023
@ti-chi-bot ti-chi-bot mentioned this pull request May 30, 2023
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #14082.

@Oreoxmt Oreoxmt deleted the revert-13731-dev/admin_pause_resume_ddl_jobs branch May 30, 2023 10:15
ti-chi-bot bot pushed a commit that referenced this pull request May 30, 2023
@ti-chi-bot
Revert "Add description on admin pause ddl jobs and `admin resume d…
a3dd2fa 
…dl jobs`" (#14078) (#14082)
@Oreoxmt Oreoxmt added the v7.1 This PR/issue applies to TiDB v7.1. label May 30, 2023
@ti-chi-bot ti-chi-bot mentioned this pull request May 31, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ran-huang ran-huang ran-huang approved these changes

@benmaoer benmaoer benmaoer approved these changes

@Benjamin2037 Benjamin2037 Benjamin2037 approved these changes

Assignees

@Oreoxmt Oreoxmt

Labels
needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. v7.1 This PR/issue applies to TiDB v7.1.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Oreoxmt @ti-chi-bot @Benjamin2037 @benmaoer @ran-huang