Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add description on admin pause ddl jobs and admin resume ddl jobs #13731

Merged
merged 3 commits into from
Apr 25, 2023
Merged

Add description on admin pause ddl jobs and admin resume ddl jobs #13731

merged 3 commits into from
Apr 25, 2023

Conversation

dhysum
Copy link
Contributor

@dhysum dhysum commented Apr 18, 2023 •
edited
Loading

First-time contributors' checklist

What is changed, added or deleted? (Required)

Add description about the new admin command:

  • admin pause ddl jobs
  • admin resume ddl jobs

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v7.1 (TiDB 7.1 versions)
  • v7.0 (TiDB 7.0 versions)
  • v6.6 (TiDB 6.6 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

Related issue number:

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 18, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • qiancai
  • ran-huang

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@CLAassistant
Copy link

CLAassistant commented Apr 18, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@ti-chi-bot ti-chi-bot added contribution This PR is from a community contributor. first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. labels Apr 18, 2023
@ti-chi-bot
Copy link
Member

Welcome @dhysum!

It looks like this is your first PR to pingcap/docs-cn 🎉.

I'm the bot to help you request reviewers, add labels and more, See available commands.

We want to make sure your contribution gets all the attention it needs!



Thank you, and welcome to pingcap/docs-cn. 😃

@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 18, 2023
@Oreoxmt
Copy link
Collaborator

Oreoxmt commented Apr 18, 2023 •
edited
Loading

/cc @Benjamin2037

@Oreoxmt Oreoxmt added translation/doing This PR’s assignee is translating this PR. v7.1 This PR/issue applies to TiDB v7.1. and removed missing-translation-status This PR does not have translation status info. labels Apr 18, 2023
ran-huang
ran-huang reviewed Apr 19, 2023
View reviewed changes
ddl-introduction.md Outdated Show resolved Hide resolved
@dhysum dhysum force-pushed the dev/admin_pause_resume_ddl_jobs branch from f94f802 to 20c6723 Compare April 19, 2023 05:41
@ran-huang ran-huang requested a review from qiancai April 19, 2023 05:48
ran-huang
ran-huang approved these changes Apr 19, 2023
View reviewed changes
ddl-introduction.md Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 19, 2023
ran-huang
ran-huang reviewed Apr 19, 2023
View reviewed changes
ddl-introduction.md Outdated Show resolved Hide resolved
@ran-huang ran-huang mentioned this pull request Apr 19, 2023
Merged
15 tasks
@ran-huang ran-huang added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Apr 19, 2023
ran-huang
ran-huang reviewed Apr 19, 2023
View reviewed changes
ddl-introduction.md Outdated Show resolved Hide resolved
ran-huang
ran-huang reviewed Apr 19, 2023
View reviewed changes
ddl-introduction.md Outdated Show resolved Hide resolved
benmaoer
benmaoer approved these changes Apr 19, 2023
View reviewed changes
Copy link
Contributor

@benmaoer benmaoer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

qiancai
qiancai approved these changes Apr 19, 2023
View reviewed changes
Copy link
Collaborator

@qiancai qiancai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

other LGTM

ddl-introduction.md Outdated Show resolved Hide resolved
ddl-introduction.md Outdated Show resolved Hide resolved
ddl-introduction.md Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot removed the status/LGT1 Indicates that a PR has LGTM 1. label Apr 19, 2023
@ti-chi-bot ti-chi-bot added the status/LGT2 Indicates that a PR has LGTM 2. label Apr 19, 2023
@dhysum dhysum force-pushed the dev/admin_pause_resume_ddl_jobs branch from 7f3bb2f to 3255a75 Compare April 20, 2023 02:07
@ti-chi-bot ti-chi-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 20, 2023
@dhysum dhysum force-pushed the dev/admin_pause_resume_ddl_jobs branch from 3255a75 to 8ab1068 Compare April 20, 2023 02:10
qiancai
qiancai reviewed Apr 20, 2023
View reviewed changes
ddl-introduction.md Outdated Show resolved Hide resolved
@ran-huang
Copy link
Contributor

/verify

@ran-huang
Copy link
Contributor

/merge

@ti-chi-bot
Copy link

ti-chi-bot bot commented Apr 25, 2023

This pull request has been accepted and is ready to merge.

Commit hash: cbd7cb3

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 25, 2023
@ran-huang
Copy link
Contributor

/hold

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 25, 2023
@ran-huang ran-huang removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 25, 2023
@ti-chi-bot ti-chi-bot bot merged commit b4034bf into pingcap:master Apr 25, 2023
Oreoxmt added a commit that referenced this pull request May 30, 2023
@Oreoxmt
Revert "Add description on admin pause ddl jobs and `admin resume d…
9b354da 
…dl jobs` (#13731)"

This reverts commit b4034bf.
@Oreoxmt Oreoxmt mentioned this pull request May 30, 2023
Merged
@ti-chi-bot ti-chi-bot mentioned this pull request May 30, 2023
Merged
ti-chi-bot pushed a commit to ti-chi-bot/docs-cn that referenced this pull request May 30, 2023
@Oreoxmt @ti-chi-bot
Revert "Add description on admin pause ddl jobs and `admin resume d…
7bf8fa0 
…dl jobs` (pingcap#13731)"

This reverts commit b4034bf.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qiancai qiancai qiancai approved these changes

@ran-huang ran-huang ran-huang approved these changes

@benmaoer benmaoer benmaoer approved these changes

@Benjamin2037 Benjamin2037 Awaiting requested review from Benjamin2037

Assignees

@ran-huang ran-huang

@dhysum dhysum

Labels
contribution This PR is from a community contributor. first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. v7.1 This PR/issue applies to TiDB v7.1.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@dhysum @ti-chi-bot @CLAassistant @Oreoxmt @ran-huang @benmaoer @qiancai