Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update-conent- for scaleout cluster and deploy cluster #8363

Merged
merged 12 commits into from
Mar 10, 2022
Merged

update-conent- for scaleout cluster and deploy cluster #8363

merged 12 commits into from
Mar 10, 2022

Conversation

qqqdan
Copy link
Contributor

@qqqdan qqqdan commented Feb 14, 2022 •
edited by shichun-0415
Loading

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 14, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • glkappe
  • shichun-0415

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@qqqdan qqqdan requested a review from shichun-0415 February 14, 2022 09:06
@ti-chi-bot ti-chi-bot requested a review from TomShawn February 14, 2022 09:06
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 14, 2022
@qqqdan qqqdan requested review from srstack and removed request for TomShawn February 14, 2022 09:06
@qqqdan qqqdan changed the title update-conent update-conent- for scaleout cluster and deploy cluster Feb 14, 2022
@shichun-0415 shichun-0415 self-assigned this Feb 14, 2022
@shichun-0415 shichun-0415 added needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. area/tiup Indicates that the Issue or PR belongs to the area of the TiUP tool. translation/doing This PR’s assignee is translating this PR. type/enhancement The issue or PR belongs to an enhancement. and removed missing-translation-status This PR does not have translation status info. labels Feb 14, 2022
@shichun-0415 shichun-0415 added the ONCALL Relates to documentation oncall. label Feb 15, 2022
@ti-chi-bot ti-chi-bot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 20, 2022
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 20, 2022
@shichun-0415 shichun-0415 requested a review from glkappe February 22, 2022 04:07
shichun-0415
shichun-0415 approved these changes Feb 25, 2022
View reviewed changes
Copy link
Contributor

@shichun-0415 shichun-0415 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 25, 2022
glkappe
glkappe approved these changes Mar 9, 2022
View reviewed changes
Copy link
Contributor

@glkappe glkappe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 9, 2022
@shichun-0415
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: b585793

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 10, 2022
@ti-chi-bot ti-chi-bot merged commit 81c4ca1 into pingcap:master Mar 10, 2022
ti-chi-bot pushed a commit to ti-chi-bot/docs-cn that referenced this pull request Mar 10, 2022
@qqqdan @ti-chi-bot
update-conent- for scaleout cluster and deploy cluster (pingcap#8363)
8d0a3b3
@ti-chi-bot ti-chi-bot mentioned this pull request Mar 10, 2022
Merged
15 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #8613.

ti-chi-bot added a commit that referenced this pull request Mar 10, 2022
@ti-chi-bot
update-conent- for scaleout cluster and deploy cluster (#8363) (#8613)
3f1c4f0
@shichun-0415 shichun-0415 mentioned this pull request May 12, 2022
Merged
14 tasks
@shichun-0415 shichun-0415 added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels May 12, 2022
This was referenced Jun 15, 2022
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shichun-0415 shichun-0415 shichun-0415 approved these changes

@srstack srstack srstack approved these changes

@glkappe glkappe glkappe approved these changes

Assignees

@shichun-0415 shichun-0415

Labels
area/tiup Indicates that the Issue or PR belongs to the area of the TiUP tool. needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. ONCALL Relates to documentation oncall. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@qqqdan @ti-chi-bot @shichun-0415 @glkappe @srstack