Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deploy using tiup: align three PRs #8603

Merged
merged 10 commits into from
Jun 15, 2022
Merged

deploy using tiup: align three PRs #8603

merged 10 commits into from
Jun 15, 2022

Conversation

shichun-0415
Copy link
Contributor

@shichun-0415 shichun-0415 commented May 12, 2022 •
edited
Loading

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v6.1 (TiDB 6.1 versions)
  • v6.0 (TiDB 6.0 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link
Member

ti-chi-bot commented May 12, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot requested a review from TomShawn May 12, 2022 10:21
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels May 12, 2022
@shichun-0415 shichun-0415 added type/enhancement The issue or PR belongs to an enhancement. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-release-6.0 area/tiup Indicates that the Issue or PR belongs to the area of the TiUP tool. and removed missing-translation-status This PR does not have translation status info. labels May 12, 2022
@shichun-0415 shichun-0415 requested a review from qqqdan May 12, 2022 10:22
@TomShawn
Copy link
Contributor

/verify

TomShawn
TomShawn reviewed May 19, 2022
View reviewed changes
scale-tidb-using-tiup.md Outdated Show resolved Hide resolved
TomShawn
TomShawn reviewed May 19, 2022
View reviewed changes
scale-tidb-using-tiup.md Outdated Show resolved Hide resolved
TomShawn
TomShawn reviewed May 19, 2022
View reviewed changes
scale-tidb-using-tiup.md Outdated Show resolved Hide resolved
TomShawn
TomShawn reviewed May 19, 2022
View reviewed changes
scale-tidb-using-tiup.md Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 19, 2022
shichun-0415
shichun-0415 commented Jun 3, 2022
View reviewed changes
scale-tidb-using-tiup.md Outdated Show resolved Hide resolved
shichun-0415
shichun-0415 commented Jun 3, 2022
View reviewed changes
scale-tidb-using-tiup.md Outdated Show resolved Hide resolved
@shichun-0415 shichun-0415 added the needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. label Jun 7, 2022
@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 10, 2022
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 14, 2022
@shichun-0415
Copy link
Contributor Author

/remove status LGT1
/status LGT2

@ti-chi-bot ti-chi-bot added the status/LGT2 Indicates that a PR has LGTM 2. label Jun 15, 2022
@shichun-0415
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 52d8d69

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 15, 2022
@ti-chi-bot ti-chi-bot merged commit 7eacee0 into pingcap:master Jun 15, 2022
ti-chi-bot pushed a commit to ti-chi-bot/docs that referenced this pull request Jun 15, 2022
@shichun-0415 @ti-chi-bot
This is an automated cherry-pick of pingcap#8603
795386e 
Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot ti-chi-bot mentioned this pull request Jun 15, 2022
Merged
14 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #8961.

@ti-chi-bot ti-chi-bot mentioned this pull request Jun 15, 2022
Merged
14 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #8962.

ti-chi-bot pushed a commit to ti-chi-bot/docs that referenced this pull request Jun 15, 2022
@shichun-0415 @ti-chi-bot
deploy using tiup: align three PRs (pingcap#8603)
18d2d41
@ti-chi-bot ti-chi-bot mentioned this pull request Jun 15, 2022
Merged
14 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #8963.

@shichun-0415 shichun-0415 deleted the fix-tiup-deploy branch June 15, 2022 02:44
ti-chi-bot added a commit that referenced this pull request Jun 15, 2022
@ti-chi-bot
deploy using tiup: align three PRs (#8603) (#8963)
d5107e2
ti-chi-bot added a commit that referenced this pull request Jun 15, 2022
@ti-chi-bot
deploy using tiup: align three PRs (#8603) (#8962)
25cce70
ti-chi-bot added a commit that referenced this pull request Jun 20, 2022
@ti-chi-bot
deploy using tiup: align three PRs (#8603) (#8961)
6a25396
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomShawn TomShawn TomShawn approved these changes

@qqqdan qqqdan qqqdan approved these changes

Assignees
No one assigned
Labels
area/tiup Indicates that the Issue or PR belongs to the area of the TiUP tool. needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. status/LGT2 Indicates that a PR has LGTM 2. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shichun-0415 @ti-chi-bot @TomShawn @qqqdan