Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

production deployment using tiup: Replace tiflash config file with config.toml #9399

Merged
merged 4 commits into from
May 11, 2022
Merged

production deployment using tiup: Replace tiflash config file with config.toml #9399

merged 4 commits into from
May 11, 2022

Conversation

shichun-0415
Copy link
Contributor

@shichun-0415 shichun-0415 commented May 10, 2022 •
edited
Loading

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v6.1 (TiDB 6.1 versions)
  • v6.0 (TiDB 6.0 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link
Member

ti-chi-bot commented May 10, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • qiancai

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot requested a review from TomShawn May 10, 2022 11:44
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 10, 2022
@shichun-0415 shichun-0415 requested a review from qqqdan May 10, 2022 11:48
@shichun-0415 shichun-0415 added type/enhancement The issue or PR belongs to an enhancement. translation/doing This PR’s assignee is translating this PR. area/tiup Indicates that the Issue or PR belongs to the area of the TiUP tool. needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-release-6.0 and removed missing-translation-status This PR does not have translation status info. labels May 10, 2022
@shichun-0415 shichun-0415 self-assigned this May 10, 2022
@shichun-0415 shichun-0415 requested review from qiancai and removed request for TomShawn May 11, 2022 02:55
@shichun-0415 shichun-0415 removed request for qqqdan and qiancai May 11, 2022 03:48
@shichun-0415 shichun-0415 removed their assignment May 11, 2022
@shichun-0415 shichun-0415 removed type/enhancement The issue or PR belongs to an enhancement. translation/doing This PR’s assignee is translating this PR. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/tiup Indicates that the Issue or PR belongs to the area of the TiUP tool. needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-release-6.0 labels May 11, 2022
@ti-chi-bot ti-chi-bot added the missing-translation-status This PR does not have translation status info. label May 11, 2022
@shichun-0415 shichun-0415 reopened this May 11, 2022
@ti-chi-bot ti-chi-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 11, 2022
@shichun-0415 shichun-0415 removed the missing-translation-status This PR does not have translation status info. label May 11, 2022
@shichun-0415 shichun-0415 added needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-release-6.0 labels May 11, 2022
@ti-chi-bot ti-chi-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 11, 2022
@shichun-0415 shichun-0415 changed the title production deployment using tiup: Add configuration description links production deployment using tiup: Replace tiflash config file with config.toml May 11, 2022
@shichun-0415 shichun-0415 requested review from qiancai and qqqdan May 11, 2022 03:58
qiancai
qiancai approved these changes May 11, 2022
View reviewed changes
Copy link
Collaborator

@qiancai qiancai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 11, 2022
@shichun-0415
Copy link
Contributor Author

/remove status LGT1
/status LGT2

@ti-chi-bot ti-chi-bot added the status/LGT2 Indicates that a PR has LGTM 2. label May 11, 2022
@shichun-0415
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 1598458

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 11, 2022
@ti-chi-bot ti-chi-bot merged commit ae21952 into pingcap:master May 11, 2022
@ti-chi-bot ti-chi-bot mentioned this pull request May 11, 2022
Merged
14 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #9410.

@shichun-0415 shichun-0415 deleted the config-parameter branch May 11, 2022 08:03
@ti-chi-bot ti-chi-bot mentioned this pull request May 11, 2022
Merged
14 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #9411.

ti-chi-bot added a commit that referenced this pull request May 11, 2022
@ti-chi-bot
production deployment using tiup: Replace tiflash config file with co…
8d48c85 
…nfig.toml (#9399) (#9411)
ti-chi-bot added a commit that referenced this pull request May 11, 2022
@ti-chi-bot
production deployment using tiup: Replace tiflash config file with co…
7f2ae3c 
…nfig.toml (#9399) (#9410)
@shichun-0415 shichun-0415 mentioned this pull request May 12, 2022
Merged
14 tasks
@shichun-0415 shichun-0415 added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels May 12, 2022
This was referenced Jun 15, 2022
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qiancai qiancai qiancai approved these changes

@qqqdan qqqdan qqqdan approved these changes

Assignees

@shichun-0415 shichun-0415

Labels
area/tiup Indicates that the Issue or PR belongs to the area of the TiUP tool. needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shichun-0415 @ti-chi-bot @qqqdan @qiancai