Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

slowquery: fix 500 when parsing binary plan fails #1518

Merged
merged 1 commit into from
May 6, 2023
Merged

slowquery: fix 500 when parsing binary plan fails #1518

merged 1 commit into from
May 6, 2023

Conversation

mornyx
Copy link
Collaborator

@mornyx mornyx commented Apr 27, 2023

close: #1515

What's changed

Fix the issue where parsing the binary plan results in an error and return 500 in such cases.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Apr 27, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • shhdgit

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@codecov-commenter
Copy link

codecov-commenter commented Apr 27, 2023 •
edited
Loading

Codecov Report

Merging #1518 (7ac556d) into master (b0aec70) will increase coverage by 0.00%.
The diff coverage is 0.00%.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #1518   +/-   ##
=======================================
  Coverage   24.72%   24.73%           
=======================================
  Files         168      168           
  Lines       15003    15000    -3     
=======================================
  Hits         3710     3710           
+ Misses      11022    11019    -3     
  Partials      271      271
Flag Coverage Δ
backend_integration 9.03% <0.00%> (+0.04%) ⬆️
backend_ut 27.25% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0aec70...7ac556d. Read the comment docs.

@baurine baurine merged commit 974b85a into pingcap:master May 6, 2023
baurine pushed a commit that referenced this pull request May 8, 2023
@mornyx @baurine
slowquery: fix 500 when parsing binary plan fails (#1518)
03b9fe7 
Signed-off-by: mornyx <[email protected]>
baurine added a commit that referenced this pull request May 8, 2023
@baurine @guo-shaoge
@HuSharp @mornyx
Release v2023.05.08.1 [skip pd_pr] (#1523)
d6e0218 
* distinguish tiflash_compute node (#1513)

* pkg: add resource manager api (#1511)


Signed-off-by: husharp <[email protected]>

* slowquery: fix 500 when parsing binary plan fails (#1518)

Signed-off-by: mornyx <[email protected]>

* feat: implement resource manager app (#1514)

* fix: fix monitoring doc ref link for tidb-dashboard op (#1520)

* fix: hide capacity warning if estimate ru fails (#1521)

* refine: add tidb and tikv cpu quota for resource manager (#1522)

* update version: 2023.05.08.1

---------

Signed-off-by: husharp <[email protected]>
Signed-off-by: mornyx <[email protected]>
Co-authored-by: guo-shaoge <[email protected]>
Co-authored-by: Hu# <[email protected]>
Co-authored-by: Yexiang Zhang <[email protected]>
@baurine baurine mentioned this pull request May 25, 2023
Closed
@mornyx
Copy link
Collaborator Author

mornyx commented May 29, 2023

Also fixed in 7.1.x by tikv/pd#6416

@mornyx mornyx deleted the issue1515 branch November 2, 2023 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shhdgit shhdgit shhdgit approved these changes

Assignees
No one assigned
Labels
status/LGT1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dashboard throws 500 for slow query detail page with invalid utf-8 error
4 participants
@mornyx @codecov-commenter @shhdgit @baurine