Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hide capacity warning if estimate ru fails #1521

Merged
merged 1 commit into from
May 6, 2023

Conversation

baurine
Copy link
Collaborator

@baurine baurine commented May 6, 2023

No description provided.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 6, 2023

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@codecov-commenter
Copy link

Codecov Report

Merging #1521 (f725a97) into master (644f0f8) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1521   +/-   ##
=======================================
  Coverage   27.25%   27.25%           
=======================================
  Files          93       93           
  Lines       10097    10097           
=======================================
  Hits         2752     2752           
  Misses       7165     7165           
  Partials      180      180           
Flag Coverage Δ
backend_ut 27.25% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 644f0f8...f725a97. Read the comment docs.

@baurine baurine merged commit f36bc54 into master May 6, 2023
@baurine baurine deleted the fix/estimate-ru-warning branch May 6, 2023 09:10
baurine added a commit that referenced this pull request May 8, 2023
* distinguish tiflash_compute node (#1513)

* pkg: add resource manager api (#1511)


Signed-off-by: husharp <[email protected]>

* slowquery: fix 500 when parsing binary plan fails (#1518)

Signed-off-by: mornyx <[email protected]>

* feat: implement resource manager app (#1514)

* fix: fix monitoring doc ref link for tidb-dashboard op (#1520)

* fix: hide capacity warning if estimate ru fails (#1521)

* refine: add tidb and tikv cpu quota for resource manager (#1522)

* update version: 2023.05.08.1

---------

Signed-off-by: husharp <[email protected]>
Signed-off-by: mornyx <[email protected]>
Co-authored-by: guo-shaoge <[email protected]>
Co-authored-by: Hu# <[email protected]>
Co-authored-by: Yexiang Zhang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants