Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

diff: add integration test #239

Merged
merged 25 commits into from
Jun 11, 2019
Merged

Conversation

WangXiangUSTC
Copy link
Contributor

@WangXiangUSTC WangXiangUSTC commented May 22, 2019

What problem does this PR solve?

sync_diff_inspector lack integration test

What is changed and how it works?

  1. refine the tests structure
  2. add a integration test for sync_diff_inspector, now only add test for snapshot and shard, will add more test later

Check List

Tests

  • Unit test
  • Integration test

@WangXiangUSTC
Copy link
Contributor Author

/run-integration-test

@zhouqiang-cl
Copy link

/run-integration-tests

WangXiangUSTC and others added 6 commits May 24, 2019 14:03
pingcap#236)

* column-mapping: set schemaID/tableID to 0 if numeric suffix is missing

* column-mapping: demand an explicit separator

* pkg/column-mapping: addressed comments

* column-mapping: addressed comments
@WangXiangUSTC
Copy link
Contributor Author

/run-integration-tests

@WangXiangUSTC
Copy link
Contributor Author

/run-integration-tests

@WangXiangUSTC
Copy link
Contributor Author

/run-integration-tests

@WangXiangUSTC
Copy link
Contributor Author

/run-integration-tests

@WangXiangUSTC
Copy link
Contributor Author

/run-integration-tests

@WangXiangUSTC
Copy link
Contributor Author

/run-integration-tests

@WangXiangUSTC
Copy link
Contributor Author

/run-integration-tests

tests/README.md Outdated Show resolved Hide resolved
tests/_utils/check_db_status Show resolved Hide resolved
tests/_utils/check_db_status Show resolved Hide resolved
tests/run.sh Show resolved Hide resolved
tests/run.sh Outdated Show resolved Hide resolved
tests/sync_diff_inspector/shard/run.sh Show resolved Hide resolved
Copy link
Member

@csuzhangxc csuzhangxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tests/README.md Outdated

## Preparations

1. The following three executables must be copied or linked into these locations:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are more than three files listed below.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

tests/README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@suzaku suzaku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WangXiangUSTC WangXiangUSTC merged commit ff58631 into pingcap:master Jun 11, 2019
@WangXiangUSTC WangXiangUSTC deleted the xiang/add_tests branch June 11, 2019 08:08
ericsyh pushed a commit that referenced this pull request Jun 24, 2019
* diff: add connection manage (#237)

* column-mapping: set schemaID/tableID to 0 if numeric suffix is missing (#236)

* column-mapping: set schemaID/tableID to 0 if numeric suffix is missing

* column-mapping: demand an explicit separator

* pkg/column-mapping: addressed comments

* column-mapping: addressed comments

* diff: some minor fix (#242)

* remove row_id (#240)

* diff: update column's length for checkpoint table (#245)

* diff: add integration test (#239)

* diff: fix num is nil (#250)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants