-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
diff: add integration test #239
Conversation
/run-integration-test |
/run-integration-tests |
pingcap#236) * column-mapping: set schemaID/tableID to 0 if numeric suffix is missing * column-mapping: demand an explicit separator * pkg/column-mapping: addressed comments * column-mapping: addressed comments
fe8e51b
to
610d6f3
Compare
/run-integration-tests |
/run-integration-tests |
/run-integration-tests |
/run-integration-tests |
/run-integration-tests |
/run-integration-tests |
/run-integration-tests |
Co-Authored-By: Xuecheng Zhang <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
tests/README.md
Outdated
|
||
## Preparations | ||
|
||
1. The following three executables must be copied or linked into these locations: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are more than three
files listed below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated
Co-Authored-By: satoru <[email protected]>
…db-tools into xiang/add_tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* diff: add connection manage (#237) * column-mapping: set schemaID/tableID to 0 if numeric suffix is missing (#236) * column-mapping: set schemaID/tableID to 0 if numeric suffix is missing * column-mapping: demand an explicit separator * pkg/column-mapping: addressed comments * column-mapping: addressed comments * diff: some minor fix (#242) * remove row_id (#240) * diff: update column's length for checkpoint table (#245) * diff: add integration test (#239) * diff: fix num is nil (#250)
What problem does this PR solve?
sync_diff_inspector lack integration test
What is changed and how it works?
Check List
Tests