diff: fix num is nil #250
Merged
diff: fix num is nil #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run-integration-tests |
csuzhangxc
reviewed
Jun 17, 2019
amyangfei
reviewed
Jun 17, 2019
| names := []string{"d", "b", "c", "b", "a"} | ||
| ages := []int{1, 2, 3, 4, 5} | ||
| ids := []string{"3", "2", "2", "4", "1", "NULL"} | ||
| names := []string{"d", "NULL", "c", "b", "a", "e"} |
There was a problem hiding this comment.
we can add more test cases to increase code path coverage later (easy to find out which code is not covered after added some coverage integration tool).
ericsyh
pushed a commit
that referenced
this pull request
Jun 24, 2019
* diff: add connection manage (#237) * column-mapping: set schemaID/tableID to 0 if numeric suffix is missing (#236) * column-mapping: set schemaID/tableID to 0 if numeric suffix is missing * column-mapping: demand an explicit separator * pkg/column-mapping: addressed comments * column-mapping: addressed comments * diff: some minor fix (#242) * remove row_id (#240) * diff: update column's length for checkpoint table (#245) * diff: add integration test (#239) * diff: fix num is nil (#250)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
fix issue https://internal.pingcap.net/jira/browse/TOOL-1289
What is changed and how it works?
judge whether data is nil at the first when compare data
Check List
Tests
Related changes