Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kill TiDB can not support cancel DDL #43854

Closed
Tracked by #39751
zimulala opened this issue May 16, 2023 · 0 comments · Fixed by #43871
Closed
Tracked by #39751

Kill TiDB can not support cancel DDL #43854

zimulala opened this issue May 16, 2023 · 0 comments · Fixed by #43871
Assignees
@zimulala
Labels
affects-7.1 This bug affects the 7.1.x(LTS) versions. may-affects-5.1 This bug maybe affects 5.1.x versions. may-affects-5.2 This bug maybe affects 5.2.x versions. may-affects-5.3 This bug maybe affects 5.3.x versions. may-affects-5.4 This bug maybe affects 5.4.x versions. may-affects-6.1 may-affects-6.5 sig/sql-infra SIG: SQL Infra type/enhancement The issue or PR belongs to an enhancement.

Comments

@zimulala
Copy link
Contributor

Enhancement

This issue support canceling DDL statements with KILL（related PR:https://github.com/pingcap/tidb/pull/35923）.
But after these PRs, when we do kill TiDB, this TiDB's DDLs may be canceled(In some cases it can't be cancelled).

This issue need do "Pause user DDL when upgrading TiDB", but these DDLs may be canceled by kill TiDB. So we consider kill TiDB can not cancel DDL.

We'll deal with this in detail when we distinguish between asynchronous and synchronous DDLs.
@zimulala zimulala added type/enhancement The issue or PR belongs to an enhancement. sig/sql-infra SIG: SQL Infra affects-7.1 This bug affects the 7.1.x(LTS) versions. labels May 16, 2023
This was referenced May 16, 2023
Merged
Closed
@ti-chi-bot ti-chi-bot mentioned this issue May 17, 2023
Merged
12 tasks
@zimulala zimulala added type/bug The issue is confirmed as a bug. severity/major labels May 17, 2023
@ti-chi-bot ti-chi-bot bot added may-affects-5.1 This bug maybe affects 5.1.x versions. may-affects-5.2 This bug maybe affects 5.2.x versions. may-affects-5.3 This bug maybe affects 5.3.x versions. may-affects-5.4 This bug maybe affects 5.4.x versions. may-affects-6.1 may-affects-6.5 labels May 17, 2023
@zimulala zimulala self-assigned this May 17, 2023
ti-chi-bot bot pushed a commit that referenced this issue May 17, 2023
@ti-chi-bot
*: Make DDL unaffected by killing TiDB instance (#43871) (#43910)
79a8433 
close #43854
@zimulala zimulala removed severity/major type/bug The issue is confirmed as a bug. labels May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zimulala zimulala

Labels
affects-7.1 This bug affects the 7.1.x(LTS) versions. may-affects-5.1 This bug maybe affects 5.1.x versions. may-affects-5.2 This bug maybe affects 5.2.x versions. may-affects-5.3 This bug maybe affects 5.3.x versions. may-affects-5.4 This bug maybe affects 5.4.x versions. may-affects-6.1 may-affects-6.5 sig/sql-infra SIG: SQL Infra type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

*: Make DDL unaffected by killing TiDB instance zimulala/tidb
1 participant
@zimulala