Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: Make DDL unaffected by killing TiDB instance (#43871) #43910

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #43871

What problem does this PR solve?

Issue Number: close #43854

Problem Summary:

  1. This issue support canceling DDL statements with KILL(related PR:https://github.com/pingcap/tidb/pull/35923).
    ---The original PR that supported this didn't seem to say cancel DDL on "kill TiDB"

  2. But after these PRs, when we do kill TiDB, this TiDB's DDLs may be canceled(In some cases it can't be cancelled).
    --- Cancel DDL is not fully supported in the case of "kill TiDB".

  3. This issue need do "Pause user DDL when upgrading TiDB", but these DDLs may be canceled by kill TiDB. So we consider kill TiDB can not cancel DDL.

  4. We'll deal with this in detail when we distinguish between asynchronous and synchronous DDLs.

What is changed and how it works?

If don't we kill TiDB can't cancel DDLs.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Make DDL unaffected by the KILL TiDB command"

@ti-chi-bot ti-chi-bot requested a review from a team as a code owner May 17, 2023 08:33
@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-7.1 This PR is cherry-picked to release-7.1 from a source PR. labels May 17, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented May 17, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lcwangchao
  • qw4990

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 17, 2023
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 17, 2023
@zimulala
Copy link
Contributor

/test check-dev2

@zimulala
Copy link
Contributor

/merge

@ti-chi-bot
Copy link

ti-chi-bot bot commented May 17, 2023

This pull request has been accepted and is ready to merge.

Commit hash: b3f157d

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label May 17, 2023
@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels May 17, 2023
@ti-chi-bot ti-chi-bot bot merged commit 79a8433 into pingcap:release-7.1 May 17, 2023
@VelocityLight VelocityLight added do-not-merge/cherry-pick-not-approved and removed cherry-pick-approved Cherry pick PR approved by release team. labels May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/cherry-pick-not-approved release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-7.1 This PR is cherry-picked to release-7.1 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants