planner: add error message for group_concat #15345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution. If your PR get merged, you will be rewarded 50 points. |
ghost
requested review from
francis0407 and
winoros
and removed request for
a team
Codecov Report
@@ Coverage Diff @@
## master #15345 +/- ##
================================================
+ Coverage 80.3966% 80.6935% +0.2969%
================================================
Files 502 502
Lines 133630 135354 +1724
================================================
+ Hits 107434 109222 +1788
+ Misses 17756 17746 -10
+ Partials 8440 8386 -54 |
zz-jason
requested review from
SunRunAway
and removed request for
francis0407 and
winoros
|
PTAL @SunRunAway |
SunRunAway
reviewed
Mar 16, 2020
| @@ -243,7 +243,8 @@ | |||
| "[planner:3586]Window 'w': frame start or end is negative, NULL or of non-integral type", | |||
| "[planner:3586]Window 'w': frame start or end is negative, NULL or of non-integral type", | |||
| "[planner:3586]Window 'w': frame start or end is negative, NULL or of non-integral type", | |||
| "TableReader(Table(t))->Sort->Window(row_number()->Column#14 over(partition by test.t.b))->Projection" | |||
| "TableReader(Table(t))->Sort->Window(row_number()->Column#14 over(partition by test.t.b))->Projection", | |||
| "[planner:1235]This version of TiDB doesn't yet support 'group_concat as window function'" | |||
Merge Master
Merge from master
SunRunAway
added
status/can-merge
|
/run-all-tests |
|
/run-cherry-picker |
sre-bot
pushed a commit
to sre-bot/tidb
that referenced
this pull request
Apr 8, 2020
Signed-off-by: sre-bot <[email protected]>
|
cherry pick to release-3.0 in PR #16163 |
sre-bot
pushed a commit
to sre-bot/tidb
that referenced
this pull request
Apr 8, 2020
Signed-off-by: sre-bot <[email protected]>
|
cherry pick to release-3.1 in PR #16166 |
|
cherry pick to release-4.0 failed |
zz-jason
pushed a commit
that referenced
this pull request
Apr 15, 2020
|
/run-cherry-picker |
|
cherry pick to release-4.0 failed |
SunRunAway
added a commit
to SunRunAway/tidb
that referenced
this pull request
Jul 20, 2020
SunRunAway
added a commit
that referenced
this pull request
Jul 20, 2020
SunRunAway
pushed a commit
that referenced
this pull request
Jul 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UCP #10996
What problem does this PR solve?
close #10996, compatible with mysql error messages when using group_cancat as window function. details ref #10996
Check List
Tests