Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: add error message for group_concat (#15345) #18686

Merged
merged 2 commits into from
Jul 20, 2020
Merged

planner: add error message for group_concat (#15345) #18686

merged 2 commits into from
Jul 20, 2020

Conversation

SunRunAway
Copy link
Contributor

@SunRunAway SunRunAway commented Jul 20, 2020 •
edited
Loading

cherry-pick #15345 to release-3.0
Note: It's a fix for #16163

UCP #10996

What problem does this PR solve?

close #10996, compatible with mysql error messages when using group_cancat as window function. details ref #10996

Check List

Tests

  • Unit test

Release note

  • add an error message for group_concat for Window function.

@SunRunAway SunRunAway requested review from zz-jason and lzmhhh123 July 20, 2020 07:33
@SunRunAway SunRunAway self-assigned this Jul 20, 2020
@SunRunAway
Copy link
Contributor Author

@zz-jason @lzmhhh123 PTAL again, thanks.

zz-jason
zz-jason reviewed Jul 20, 2020
View reviewed changes
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 20, 2020
lzmhhh123
lzmhhh123 previously approved these changes Jul 20, 2020
View reviewed changes
Copy link
Contributor

@lzmhhh123 lzmhhh123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 20, 2020
ti-srebot
ti-srebot previously approved these changes Jul 20, 2020
View reviewed changes
@SunRunAway
Copy link
Contributor Author

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 20, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Jul 20, 2020

No release note, Please follow https://github.com/pingcap/community/blob/master/contributors/release-note-checker.md

@ti-srebot
Copy link
Contributor

/run-all-tests

@SunRunAway SunRunAway dismissed stale reviews from ti-srebot and lzmhhh123 via 8709342 July 20, 2020 09:12
@sre-bot
Copy link
Contributor

sre-bot commented Jul 20, 2020

No release note, Please follow https://github.com/pingcap/community/blob/master/contributors/release-note-checker.md

@SunRunAway
Copy link
Contributor Author

/run-all-tests

@ti-srebot
Copy link
Contributor

@SunRunAway merge failed.

@SunRunAway
Copy link
Contributor Author

/rebuild

@SunRunAway SunRunAway merged commit 27b8693 into pingcap:release-3.0 Jul 20, 2020
@SunRunAway SunRunAway deleted the release-3.0-15345 branch July 20, 2020 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zz-jason zz-jason zz-jason left review comments

@lzmhhh123 lzmhhh123 lzmhhh123 approved these changes

@ti-srebot ti-srebot ti-srebot left review comments

Assignees

@SunRunAway SunRunAway

Labels
sig/planner SIG: Planner status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/3.0-cherry-pick
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@SunRunAway @sre-bot @ti-srebot @zz-jason @lzmhhh123