Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sessionctx: Fix tidb_gc_scan_lock_mode sysvar doesn't show correct default value on new clusters #25112

Merged
merged 5 commits into from
Jun 3, 2021
Merged

sessionctx: Fix tidb_gc_scan_lock_mode sysvar doesn't show correct default value on new clusters #25112

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3d6e30c
sessionctx: Fix tidb_gc_scan_lock_mode sysvar doesn't show correct de…
MyonKeminta Jun 3, 2021
0071a5a
Merge branch 'master' into m/fix-gc-scan-lock-mode-default
ti-chi-bot Jun 3, 2021
cae91f2
Merge branch 'master' into m/fix-gc-scan-lock-mode-default
ti-chi-bot Jun 3, 2021
f50f667
Merge branch 'master' into m/fix-gc-scan-lock-mode-default
ti-chi-bot Jun 3, 2021
d794eac
Merge branch 'master' into m/fix-gc-scan-lock-mode-default
ti-chi-bot Jun 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sessionctx/variable/sysvar.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1667,7 +1667,7 @@ var defaultSysVars = []*SysVar{
{Scope: ScopeGlobal, Name: TiDBGCRunInterval, Value: "10m0s", Type: TypeDuration, MinValue: int64(time.Minute * 10), MaxValue: math.MaxInt64},
{Scope: ScopeGlobal, Name: TiDBGCLifetime, Value: "10m0s", Type: TypeDuration, MinValue: int64(time.Minute * 10), MaxValue: math.MaxInt64},
{Scope: ScopeGlobal, Name: TiDBGCConcurrency, Value: "-1", Type: TypeInt, MinValue: 1, MaxValue: 128, AllowAutoValue: true},
{Scope: ScopeGlobal, Name: TiDBGCScanLockMode, Value: "PHYSICAL", Type: TypeEnum, PossibleValues: []string{"PHYSICAL", "LEGACY"}},
{Scope: ScopeGlobal, Name: TiDBGCScanLockMode, Value: "LEGACY", Type: TypeEnum, PossibleValues: []string{"PHYSICAL", "LEGACY"}},

// variable for top SQL feature.
{Scope: ScopeGlobal | ScopeSession, Name: TiDBEnableTopSQL, Value: BoolToOnOff(DefTiDBTopSQLEnable), Type: TypeBool, AllowEmpty: true, GetSession: func(s *SessionVars) (string, error) {
Expand Down