Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sessionctx: Fix tidb_gc_scan_lock_mode sysvar doesn't show correct default value on new clusters #25112

Merged

Conversation

MyonKeminta
Copy link
Contributor

@MyonKeminta MyonKeminta commented Jun 3, 2021

What problem does this PR solve?

Issue Number: close #25100

Problem Summary: When a new cluster is deployed and it has never run GC, the tikv_gc_scan_lock_mode doesn't exist. In this case, select @@global.tidb_gc_scan_lock_mode will return the default value defined in sysvar.go. However, it's inconsistent with the actual default config, so it returns "PHYSICAL" while the actual mode is "LEGACY".

What is changed and how it works?

What's Changed: Changed the default value of sysvar global.tidb_gc_scan_lock_mode to "LEGACY".

Related changes

  • Need to cherry-pick to the release branch
    • release-5.0

Check List

Tests

  • Manual test (add detailed scripts or steps below)
    • Deploy the cluster by tiup playground and run "select @@global.tidb_gc_scan_lock_mode" immediately, an it returns "LEGACY".

Side effects

  • None

Release note

  • Fix a bug that a new cluster's "tidb_gc_scan_lock_mode" global variable shows "PHYSICAL" instead of the actual default mode "LEGACY".

@MyonKeminta MyonKeminta added the sig/transaction SIG:Transaction label Jun 3, 2021
@ti-chi-bot ti-chi-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 3, 2021
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 3, 2021
@youjiali1995 youjiali1995 requested a review from sticnarf June 3, 2021 13:13
@bb7133
Copy link
Member

bb7133 commented Jun 3, 2021

So the point is, we changed the default value back to 'legacy'(pingcap/docs#5136) so the sys vars should be updated accordingly, right?

@bb7133
Copy link
Member

bb7133 commented Jun 3, 2021

lgtm and cc @morgo

@ti-chi-bot
Copy link
Member

@bb7133: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@bb7133
Copy link
Member

bb7133 commented Jun 3, 2021

/merge

@ti-chi-bot
Copy link
Member

@bb7133: /merge is only allowed for the committers, you can assign this pull request to the committer in list by filling /assign @committer in the comment to help merge this pull request.

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Copy link
Contributor

@sticnarf sticnarf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • sticnarf
  • youjiali1995

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 3, 2021
@sticnarf
Copy link
Contributor

sticnarf commented Jun 3, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 3d6e30c

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 3, 2021
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #25118

@MyonKeminta MyonKeminta deleted the m/fix-gc-scan-lock-mode-default branch June 4, 2021 04:57
@MyonKeminta
Copy link
Contributor Author

So the point is, we changed the default value back to 'legacy'(pingcap/docs#5136) so the sys vars should be updated accordingly, right?

Currently, yes.

MyonKeminta added a commit to ti-srebot/tidb that referenced this pull request Jun 4, 2021
ti-chi-bot pushed a commit that referenced this pull request Aug 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-cherry-pick-release-5.0 sig/transaction SIG:Transaction size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

in v5.0.2, tidb_gc_scan_lock_mode default value is different in scratch installed server and upgrade server
6 participants