-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sessionctx: Fix tidb_gc_scan_lock_mode sysvar doesn't show correct default value on new clusters #25112
sessionctx: Fix tidb_gc_scan_lock_mode sysvar doesn't show correct default value on new clusters #25112
Conversation
…fault value on new clusters
So the point is, we changed the default value back to 'legacy'(pingcap/docs#5136) so the sys vars should be updated accordingly, right? |
lgtm and cc @morgo |
@bb7133: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
/merge |
@bb7133: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 3d6e30c
|
cherry pick to release-5.0 in PR #25118 |
Currently, yes. |
What problem does this PR solve?
Issue Number: close #25100
Problem Summary: When a new cluster is deployed and it has never run GC, the
tikv_gc_scan_lock_mode
doesn't exist. In this case,select @@global.tidb_gc_scan_lock_mode
will return the default value defined in sysvar.go. However, it's inconsistent with the actual default config, so it returns "PHYSICAL" while the actual mode is "LEGACY".What is changed and how it works?
What's Changed: Changed the default value of sysvar
global.tidb_gc_scan_lock_mode
to "LEGACY".Related changes
Check List
Tests
Side effects
Release note